Added model wrappers for DeepFM and DLRM #3115
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D76916471 |
|
This pull request was exported from Phabricator. Differential Revision: D76916471 |
SSYernar
added a commit
to SSYernar/torchrec
that referenced
this pull request
Jun 18, 2025
Summary: Pull Request resolved: pytorch#3115 * Added model wrappers for DeepFM and DLRM. The wrapper will take ModelInput as an only parameter in the forward method. * Added the unit tests to cover the models' wrappers Differential Revision: D76916471
SSYernar
force-pushed
the
export-D76916471
branch
from
05ec6a0 to
3cc5d1e
Compare
SSYernar
added a commit
to SSYernar/torchrec
that referenced
this pull request
Jun 19, 2025
Summary: * Added model wrappers for DeepFM and DLRM. The wrapper will take ModelInput as an only parameter in the forward method. * Added the unit tests to cover the models' wrappers Differential Revision: D76916471
SSYernar
force-pushed
the
export-D76916471
branch
from
3cc5d1e to
562f054
Compare
|
This pull request was exported from Phabricator. Differential Revision: D76916471 |
SSYernar
force-pushed
the
export-D76916471
branch
from
562f054 to
3f7c960
Compare
SSYernar
added a commit
to SSYernar/torchrec
that referenced
this pull request
Jun 19, 2025
Summary: Pull Request resolved: pytorch#3115 * Added model wrappers for DeepFM and DLRM. The wrapper will take ModelInput as an only parameter in the forward method. * Added the unit tests to cover the models' wrappers Differential Revision: D76916471
SSYernar
force-pushed
the
export-D76916471
branch
from
3f7c960 to
ebbed47
Compare
SSYernar
added a commit
to SSYernar/torchrec
that referenced
this pull request
Jun 23, 2025
Summary: * Added model wrapper for DeepFM. The wrapper will take ModelInput as an only parameter in the forward method. * Added the unit tests to cover the model's wrapper Differential Revision: D76916471
|
This pull request was exported from Phabricator. Differential Revision: D76916471 |
SSYernar
added a commit
to SSYernar/torchrec
that referenced
this pull request
Jun 23, 2025
Summary: * Added model wrapper for DeepFM. The wrapper will take ModelInput as an only parameter in the forward method. * Added the parameterized unit tests to cover the model's wrapper Differential Revision: D76916471
Summary: * Added model wrapper for DeepFM. The wrapper will take ModelInput as an only parameter in the forward method. The forward method will return just the prediction if it's in inference mode and losses with prediction if it's in training mode. (Because training pipeline expects loss and prediction. See https://github.com/pytorch/torchrec/blob/main/torchrec/distributed/train_pipeline/train_pipelines.py#L670) * Added the parameterized unit tests to cover the model's wrapper Differential Revision: D76916471
SSYernar
force-pushed
the
export-D76916471
branch
from
ebbed47 to
a978020
Compare
|
This pull request was exported from Phabricator. Differential Revision: D76916471 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Differential Revision: D76916471