Add unsharded module reference to sharded modules #2901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D73407830 |
aporialiao
added a commit
to aporialiao/torchrec
that referenced
this pull request
Apr 22, 2025
Summary: Adding a simple unsharded module reference to sharded modules. This will be used in Dynamic Sharding by `DistributedModelParallel` to reshard an already-sharded_module. As DMP is created with only one-way relationship in mind, accessing the unsharded module type will help determine which sharder to use in 'resharding'. Differential Revision: D73407830
aporialiao
force-pushed
the
export-D73407830
branch
from
892d66d to
09fcea8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D73407830 |
aporialiao
added a commit
to aporialiao/torchrec
that referenced
this pull request
Apr 23, 2025
Summary: Adding a simple unsharded module reference to sharded modules. This will be used in Dynamic Sharding by `DistributedModelParallel` to reshard an already-sharded_module. As DMP is created with only one-way relationship in mind, accessing the unsharded module type will help determine which sharder to use in 'resharding'. Most of the changes here are simply to add in the property in where ShardedModule or it's wrapper ShardedEmbeddingModule is used. Differential Revision: D73407830
aporialiao
force-pushed
the
export-D73407830
branch
from
09fcea8 to
4237c7e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D73407830 |
aporialiao
added a commit
to aporialiao/torchrec
that referenced
this pull request
Apr 23, 2025
Summary: Adding a simple unsharded module reference to sharded modules. This will be used in Dynamic Sharding by `DistributedModelParallel` to reshard an already-sharded_module. As DMP is created with only one-way relationship in mind, accessing the unsharded module type will help determine which sharder to use in 'resharding'. Most of the changes here are simply to add in the property in where ShardedModule or it's wrapper ShardedEmbeddingModule is used. Differential Revision: D73407830
aporialiao
force-pushed
the
export-D73407830
branch
from
4237c7e to
e18ff0a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D73407830 |
Summary: Pull Request resolved: pytorch#2901 Adding a simple unsharded module reference to sharded modules. This will be used in Dynamic Sharding by `DistributedModelParallel` to reshard an already-sharded_module. As DMP is created with only one-way relationship in mind, accessing the unsharded module type will help determine which sharder to use in 'resharding'. Most of the changes here are simply to add in the property in where ShardedModule or it's wrapper ShardedEmbeddingModule is used. Differential Revision: D73407830
|
This pull request was exported from Phabricator. Differential Revision: D73407830 |
aporialiao
force-pushed
the
export-D73407830
branch
from
e18ff0a to
103f396
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Adding a simple unsharded module reference to sharded modules. This will be used in Dynamic Sharding by
DistributedModelParallelto reshard an already-sharded_module.As DMP is created with only one-way relationship in mind, accessing the unsharded module type will help determine which sharder to use in 'resharding'.
Differential Revision: D73407830