Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teach is_signature_compatible() to dig into similar annotations #2693

Closed
wants to merge 1 commit into from
Closed

Teach is_signature_compatible() to dig into similar annotations #2693

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 29 additions & 1 deletion torchrec/schema/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,32 @@
# pyre-strict

import inspect
import typing
from typing import Any


def _is_annot_compatible(prev: object, curr: object) -> bool:
if prev == curr:
return True

if not (prev_origin := typing.get_origin(prev)):
return False
if not (curr_origin := typing.get_origin(curr)):
return False

if prev_origin != curr_origin:
return False

prev_args = typing.get_args(prev)
curr_args = typing.get_args(curr)
if len(prev_args) != len(curr_args):
return False

for prev_arg, curr_arg in zip(prev_args, curr_args):
if not _is_annot_compatible(prev_arg, curr_arg):
return False

return True


def is_signature_compatible(
Expand Down Expand Up @@ -84,6 +110,8 @@ def is_signature_compatible(
return False

# TODO: Account for Union Types?
if current_signature.return_annotation != previous_signature.return_annotation:
if not _is_annot_compatible(
previous_signature.return_annotation, current_signature.return_annotation
):
return False
return True
Loading