Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use spawn instead of forkserver for MTIA #2691

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions torchrec/distributed/test_utils/multi_process.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@

#!/usr/bin/env python3

import logging
import multiprocessing
import os
import unittest
Expand All @@ -24,11 +25,6 @@
)


# AMD's HIP runtime doesn't seem to work with forkserver; hipMalloc will fail
# Therefore we use spawn for HIP runtime until AMD fixes the issue
_MP_INIT_MODE = "forkserver" if torch.version.hip is None else "spawn"


class MultiProcessContext:
def __init__(
self,
Expand Down Expand Up @@ -98,6 +94,15 @@ def __exit__(self, exc_type, exc_instance, traceback) -> None:


class MultiProcessTestBase(unittest.TestCase):
def __init__(
self, methodName: str = "runTest", mp_init_mode: str = "forkserver"
) -> None:
super().__init__(methodName)

# AMD's HIP runtime doesn't seem to work with forkserver; hipMalloc will fail
# Therefore we use spawn for HIP runtime until AMD fixes the issue
self._mp_init_mode: str = mp_init_mode if torch.version.hip is None else "spawn"
logging.info(f"Using {self._mp_init_mode} for multiprocessing")

@seed_and_log
def setUp(self) -> None:
Expand Down Expand Up @@ -131,7 +136,7 @@ def _run_multi_process_test(
# pyre-ignore
**kwargs,
) -> None:
ctx = multiprocessing.get_context(_MP_INIT_MODE)
ctx = multiprocessing.get_context(self._mp_init_mode)
processes = []
for rank in range(world_size):
kwargs["rank"] = rank
Expand All @@ -157,7 +162,7 @@ def _run_multi_process_test_per_rank(
world_size: int,
kwargs_per_rank: List[Dict[str, Any]],
) -> None:
ctx = multiprocessing.get_context(_MP_INIT_MODE)
ctx = multiprocessing.get_context(self._mp_init_mode)
processes = []
for rank in range(world_size):
kwargs = {}
Expand Down
Loading