Add VBE support for PositionWeightedModuleCollection #2647
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request was exported from Phabricator. Differential Revision: D67526005 |
facebook-github-bot
added
CLA Signed
AlbertDachiChen
force-pushed
the
export-D67526005
branch
from
b6ceaed to
8b5eca7
Compare
AlbertDachiChen
added a commit
to AlbertDachiChen/torchrec
that referenced
this pull request
Jan 4, 2025
Summary: As titled, we have seen wins from position encoding in modeling and would like to leverage PositionWeightedModuleCollection to reduce the cost https://fb.workplace.com/groups/204375858345877/permalink/884618276988295/ I have a stack locally that show NE equivalence between PositionWeightedModuleCollection and position encoding in modeling {F1974047979} Given IG has adopted VBE, I am adding necessary plumbing for VBE in PositionWeightedModuleCollection **Diffs will land after code freeze but publish first to get the review underway** Reviewed By: TroyGarden Differential Revision: D67526005
|
This pull request was exported from Phabricator. Differential Revision: D67526005 |
AlbertDachiChen
added a commit
to AlbertDachiChen/torchrec
that referenced
this pull request
Jan 4, 2025
Summary: As titled, we have seen wins from position encoding in modeling and would like to leverage PositionWeightedModuleCollection to reduce the cost https://fb.workplace.com/groups/204375858345877/permalink/884618276988295/ I have a stack locally that show NE equivalence between PositionWeightedModuleCollection and position encoding in modeling {F1974047979} Given IG has adopted VBE, I am adding necessary plumbing for VBE in PositionWeightedModuleCollection **Diffs will land after code freeze but publish first to get the review underway** Reviewed By: TroyGarden Differential Revision: D67526005
AlbertDachiChen
force-pushed
the
export-D67526005
branch
from
8b5eca7 to
d9603da
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67526005 |
Summary: As titled, we have seen wins from position encoding in modeling and would like to leverage PositionWeightedModuleCollection to reduce the cost https://fb.workplace.com/groups/204375858345877/permalink/884618276988295/ I have a stack locally that show NE equivalence between PositionWeightedModuleCollection and position encoding in modeling {F1974047979} Given IG has adopted VBE, I am adding necessary plumbing for VBE in PositionWeightedModuleCollection **Diffs will land after code freeze but publish first to get the review underway** Reviewed By: TroyGarden Differential Revision: D67526005
AlbertDachiChen
force-pushed
the
export-D67526005
branch
from
d9603da to
6980187
Compare
|
This pull request was exported from Phabricator. Differential Revision: D67526005 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
As titled, we have seen wins from position encoding in modeling and would like to leverage PositionWeightedModuleCollection to reduce the cost https://fb.workplace.com/groups/204375858345877/permalink/884618276988295/
I have a stack locally that show NE equivalence between PositionWeightedModuleCollection and position encoding in modeling
{F1974047979}
Given IG has adopted VBE, I am adding necessary plumbing for VBE in PositionWeightedModuleCollection
Diffs will land after code freeze but publish first to get the review underway
Differential Revision: D67526005