Re-land D66465376 #2637
Open
Re-land D66465376 #2637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D66460392 |
TroyGarden
added a commit
to TroyGarden/torchrec
that referenced
this pull request
Dec 14, 2024
Summary:
Re-land diff D66465376
NOTE: use jit.ignore on the forward function to get rid of jit script error with `TensorDict`
```
def test_td_scripting(self) -> None:
class TestModule(torch.nn.Module):
torch.jit.ignore # <----- test fails without this ignore
def forward(self, x: Union[TensorDict, KeyedJaggedTensor]) -> torch.Tensor:
if isinstance(x, TensorDict):
keys = list(x.keys())
return torch.cat([x[key]._values for key in keys], dim=0)
else:
return x._values
m = TestModule()
gm = torch.fx.symbolic_trace(m)
jm = torch.jit.script(gm)
values = torch.tensor([0, 1, 2, 3, 2, 3, 4])
kjt = KeyedJaggedTensor.from_offsets_sync(
keys=["f1", "f2", "f3"],
values=values,
offsets=torch.tensor([0, 2, 2, 3, 4, 5, 7]),
)
torch.testing.assert_allclose(jm(kjt), values)
```
Differential Revision: D66460392
TroyGarden
added a commit
to TroyGarden/torchrec
that referenced
this pull request
Dec 15, 2024
Summary:
Re-land diff D66465376
NOTE: use jit.ignore on the forward function to get rid of jit script error with `TensorDict`
```
def test_td_scripting(self) -> None:
class TestModule(torch.nn.Module):
torch.jit.ignore # <----- test fails without this ignore
def forward(self, x: Union[TensorDict, KeyedJaggedTensor]) -> torch.Tensor:
if isinstance(x, TensorDict):
keys = list(x.keys())
return torch.cat([x[key]._values for key in keys], dim=0)
else:
return x._values
m = TestModule()
gm = torch.fx.symbolic_trace(m)
jm = torch.jit.script(gm)
values = torch.tensor([0, 1, 2, 3, 2, 3, 4])
kjt = KeyedJaggedTensor.from_offsets_sync(
keys=["f1", "f2", "f3"],
values=values,
offsets=torch.tensor([0, 2, 2, 3, 4, 5, 7]),
)
torch.testing.assert_allclose(jm(kjt), values)
```
Differential Revision: D66460392
Summary:
Re-land diff D66465376
NOTE: use jit.ignore on the forward function to get rid of jit script error with `TensorDict`
```
def test_td_scripting(self) -> None:
class TestModule(torch.nn.Module):
torch.jit.ignore # <----- test fails without this ignore
def forward(self, x: Union[TensorDict, KeyedJaggedTensor]) -> torch.Tensor:
if isinstance(x, TensorDict):
keys = list(x.keys())
return torch.cat([x[key]._values for key in keys], dim=0)
else:
return x._values
m = TestModule()
gm = torch.fx.symbolic_trace(m)
jm = torch.jit.script(gm)
values = torch.tensor([0, 1, 2, 3, 2, 3, 4])
kjt = KeyedJaggedTensor.from_offsets_sync(
keys=["f1", "f2", "f3"],
values=values,
offsets=torch.tensor([0, 2, 2, 3, 4, 5, 7]),
)
torch.testing.assert_allclose(jm(kjt), values)
```
Differential Revision: D66460392
TroyGarden
added a commit
to TroyGarden/torchrec
that referenced
this pull request
Dec 30, 2024
Summary:
Re-land diff D66465376
NOTE: use jit.ignore on the forward function to get rid of jit script error with `TensorDict`
```
def test_td_scripting(self) -> None:
class TestModule(torch.nn.Module):
torch.jit.ignore # <----- test fails without this ignore
def forward(self, x: Union[TensorDict, KeyedJaggedTensor]) -> torch.Tensor:
if isinstance(x, TensorDict):
keys = list(x.keys())
return torch.cat([x[key]._values for key in keys], dim=0)
else:
return x._values
m = TestModule()
gm = torch.fx.symbolic_trace(m)
jm = torch.jit.script(gm)
values = torch.tensor([0, 1, 2, 3, 2, 3, 4])
kjt = KeyedJaggedTensor.from_offsets_sync(
keys=["f1", "f2", "f3"],
values=values,
offsets=torch.tensor([0, 2, 2, 3, 4, 5, 7]),
)
torch.testing.assert_allclose(jm(kjt), values)
```
Differential Revision: D66460392
TroyGarden
force-pushed
the
export-D66460392
branch
from
1ff1d8b to
250e447
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66460392 |
TroyGarden
added a commit
to TroyGarden/torchrec
that referenced
this pull request
Dec 30, 2024
Summary:
Re-land diff D66465376
NOTE: use jit.ignore on the forward function to get rid of jit script error with `TensorDict`
```
def test_td_scripting(self) -> None:
class TestModule(torch.nn.Module):
torch.jit.ignore # <----- test fails without this ignore
def forward(self, x: Union[TensorDict, KeyedJaggedTensor]) -> torch.Tensor:
if isinstance(x, TensorDict):
keys = list(x.keys())
return torch.cat([x[key]._values for key in keys], dim=0)
else:
return x._values
m = TestModule()
gm = torch.fx.symbolic_trace(m)
jm = torch.jit.script(gm)
values = torch.tensor([0, 1, 2, 3, 2, 3, 4])
kjt = KeyedJaggedTensor.from_offsets_sync(
keys=["f1", "f2", "f3"],
values=values,
offsets=torch.tensor([0, 2, 2, 3, 4, 5, 7]),
)
torch.testing.assert_allclose(jm(kjt), values)
```
Differential Revision: D66460392
TroyGarden
added a commit
to TroyGarden/torchrec
that referenced
this pull request
Dec 31, 2024
Summary:
Re-land diff D66465376
NOTE: use jit.ignore on the forward function to get rid of jit script error with `TensorDict`
```
def test_td_scripting(self) -> None:
class TestModule(torch.nn.Module):
torch.jit.ignore # <----- test fails without this ignore
def forward(self, x: Union[TensorDict, KeyedJaggedTensor]) -> torch.Tensor:
if isinstance(x, TensorDict):
keys = list(x.keys())
return torch.cat([x[key]._values for key in keys], dim=0)
else:
return x._values
m = TestModule()
gm = torch.fx.symbolic_trace(m)
jm = torch.jit.script(gm)
values = torch.tensor([0, 1, 2, 3, 2, 3, 4])
kjt = KeyedJaggedTensor.from_offsets_sync(
keys=["f1", "f2", "f3"],
values=values,
offsets=torch.tensor([0, 2, 2, 3, 4, 5, 7]),
)
torch.testing.assert_allclose(jm(kjt), values)
```
Differential Revision: D66460392
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Re-land diff D66465376
NOTE: use jit.ignore on the forward function to get rid of jit script error with
TensorDictDifferential Revision: D66460392