[TorchRec] Add support for FakeProcessGroup for EBC #2228
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D51095381 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D51095381 |
TroyGarden
force-pushed
the
export-D51095381
branch
from
a18ae0b to
fec964b
Compare
TroyGarden
added a commit
that referenced
this pull request
Jul 13, 2024
Summary: Pull Request resolved: #2228 # context Differential Revision: D51095381
|
This pull request was exported from Phabricator. Differential Revision: D51095381 |
TroyGarden
added a commit
that referenced
this pull request
Jul 13, 2024
Summary: Pull Request resolved: #2228 # context Differential Revision: D51095381
TroyGarden
force-pushed
the
export-D51095381
branch
2 times, most recently
from
52da704 to
9558fcf
Compare
TroyGarden
added a commit
that referenced
this pull request
Jul 13, 2024
Summary: Pull Request resolved: #2228 # context Differential Revision: D51095381
|
This pull request was exported from Phabricator. Differential Revision: D51095381 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D51095381 |
TroyGarden
added a commit
that referenced
this pull request
Jul 14, 2024
Summary: Pull Request resolved: #2228 # context Differential Revision: D51095381
TroyGarden
force-pushed
the
export-D51095381
branch
from
9558fcf to
f566f3b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51095381 |
TroyGarden
added a commit
that referenced
this pull request
Jul 14, 2024
Summary: Pull Request resolved: #2228 # context Differential Revision: D51095381
TroyGarden
force-pushed
the
export-D51095381
branch
from
f566f3b to
23f61b2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51095381 |
TroyGarden
added a commit
that referenced
this pull request
Jul 14, 2024
Summary: Pull Request resolved: #2228 # context Differential Revision: D51095381
TroyGarden
force-pushed
the
export-D51095381
branch
from
23f61b2 to
9c00b97
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51095381 |
TroyGarden
added a commit
that referenced
this pull request
Jul 14, 2024
Summary: Pull Request resolved: #2228 # context Differential Revision: D51095381
TroyGarden
force-pushed
the
export-D51095381
branch
from
9c00b97 to
b2edcd1
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51095381 |
TroyGarden
added a commit
that referenced
this pull request
Jul 16, 2024
Summary: Pull Request resolved: #2228 # context Differential Revision: D51095381
TroyGarden
force-pushed
the
export-D51095381
branch
from
b2edcd1 to
4fd0789
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51095381 |
TroyGarden
added a commit
that referenced
this pull request
Jul 16, 2024
Summary: Pull Request resolved: #2228 # context Differential Revision: D51095381
TroyGarden
force-pushed
the
export-D51095381
branch
from
4fd0789 to
f6b006b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51095381 |
TroyGarden
added a commit
that referenced
this pull request
Jul 16, 2024
Summary: Pull Request resolved: #2228 # context Differential Revision: D51095381
TroyGarden
force-pushed
the
export-D51095381
branch
from
f6b006b to
1727ecf
Compare
facebook-github-bot
force-pushed
the
export-D51095381
branch
from
1727ecf to
016df76
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51095381 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 9, 2024
Summary:
# context
* use FakeProcessGroup to mimic the multi-process tests
* can use `_test_compile_fake_pg_fn` as the single-process VB compile test
```
from torchrec.distributed.tests.test_pt2_multiprocess import _test_compile_fake_pg_fn
_test_compile_fake_pg_fn(
rank=0,
world_size=2,
)
```
reference: D59637444
NOTE: right now only tested for EBC, not sure about other sparse modules like PEA or VLE, which shouldn't be too hard to add similar changes.
Differential Revision: D51095381
facebook-github-bot
force-pushed
the
export-D51095381
branch
from
016df76 to
9e02ba2
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51095381 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D51095381 |
TroyGarden
added a commit
that referenced
this pull request
Aug 9, 2024
Summary: Pull Request resolved: #2228 # context * use FakeProcessGroup to mimic the multi-process tests * can use `_test_compile_fake_pg_fn` as the single-process VB compile test ``` from torchrec.distributed.tests.test_pt2_multiprocess import _test_compile_fake_pg_fn _test_compile_fake_pg_fn( rank=0, world_size=2, ) ``` reference: D59637444 NOTE: right now only tested for EBC, not sure about other sparse modules like PEA or VLE, which shouldn't be too hard to add similar changes. Differential Revision: D51095381
TroyGarden
force-pushed
the
export-D51095381
branch
from
9e02ba2 to
46657d2
Compare
Summary: Pull Request resolved: #2228 # context * use FakeProcessGroup to mimic the multi-process tests * can use `_test_compile_fake_pg_fn` as the single-process VB compile test ``` from torchrec.distributed.tests.test_pt2_multiprocess import _test_compile_fake_pg_fn _test_compile_fake_pg_fn( rank=0, world_size=2, ) ``` reference: D59637444 NOTE: right now only tested for EBC, not sure about other sparse modules like PEA or VLE, which shouldn't be too hard to add similar changes. Reviewed By: ezyang Differential Revision: D51095381
|
This pull request was exported from Phabricator. Differential Revision: D51095381 |
TroyGarden
force-pushed
the
export-D51095381
branch
from
46657d2 to
e35c010
Compare
TroyGarden
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: # context
Differential Revision: D51095381