fix cpu test issue "CMake Error: Unknown argument: -v" #2208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D56152144 |
Summary: Pull Request resolved: pytorch#2208 # context * TorchRec CPU Unit Test is failing: [test](https://github.com/pytorch/torchrec/actions/runs/9785198706) ``` + conda run -n build_binary ctest -v . + local cmd=run + case "$cmd" in + __conda_exe run -n build_binary ctest -v . + /opt/conda/bin/conda run -n build_binary ctest -v . CMake Error: Unknown argument: -v CMake Error: Run 'ctest --help' for all supported options. ERROR conda.cli.main_run:execute(47): `conda run ctest -v .` failed. (See above for error) ``` * this is because the cmake synatx has changed from "-v" to "-V" * there is a recent CMAKE version bump ``` CMake Deprecation Warning at aten/src/ATen/native/quantized/cpu/qnnpack/deps/clog/CMakeLists.txt:7 (cmake_minimum_required): Compatibility with CMake < 3.5 will be removed from a future version of CMake. ``` Differential Revision: D56152144
|
This pull request was exported from Phabricator. Differential Revision: D56152144 |
TroyGarden
force-pushed
the
export-D56152144
branch
from
8d06f43 to
aad1927
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
context
Differential Revision: D56152144