-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Register serialized name to KJT/JT #1713
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request was exported from Phabricator. Differential Revision: D53857843 |
660c231
to
a695a2f
Compare
angelayi
added a commit
to angelayi/torchrec
that referenced
this pull request
Feb 16, 2024
Summary: Trying to reland D51312977. Hopefully this wont break any torch packages as D53139358 recently did a similar change where called `register_pytree_node` with an extra new argument, `flatten_with_keys_fn`, which was added recently in D52547850. Differential Revision: D53857843
This pull request was exported from Phabricator. Differential Revision: D53857843 |
a695a2f
to
2cdfc75
Compare
angelayi
added a commit
to angelayi/torchrec
that referenced
this pull request
Feb 21, 2024
Summary: Trying to reland D51312977. Hopefully this wont break any torch packages as D53139358 recently did a similar change where called `register_pytree_node` with an extra new argument, `flatten_with_keys_fn`, which was added recently in D52547850. Reviewed By: henrylhtsang Differential Revision: D53857843
This pull request was exported from Phabricator. Differential Revision: D53857843 |
angelayi
added a commit
to angelayi/torchrec
that referenced
this pull request
Feb 21, 2024
Summary: Trying to reland D51312977. Hopefully this wont break any torch packages as D53139358 recently did a similar change where called `register_pytree_node` with an extra new argument, `flatten_with_keys_fn`, which was added recently in D52547850. Reviewed By: henrylhtsang Differential Revision: D53857843
2cdfc75
to
5044808
Compare
This pull request was exported from Phabricator. Differential Revision: D53857843 |
Summary: Trying to reland D51312977. Hopefully this wont break any torch packages as D53139358 recently did a similar change where called `register_pytree_node` with an extra new argument, `flatten_with_keys_fn`, which was added recently in D52547850. Reviewed By: henrylhtsang Differential Revision: D53857843
5044808
to
7ff35b5
Compare
This pull request was exported from Phabricator. Differential Revision: D53857843 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
fb-exported
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Trying to reland D51312977. Hopefully this wont break any torch
packages as D53139358 recently did a similar change where called
register_pytree_node
with an extra new argument,flatten_with_keys_fn
,which was added recently in D52547850.
Differential Revision: D53857843