-
Notifications
You must be signed in to change notification settings - Fork 479
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
adding tensordict into targets to avoid package issue (#2593)
Summary: Pull Request resolved: #2593 # context * to avoid test failures like the following: https://www.internalfb.com/diff/D65103519?dst_version_fbid=450279051096758 {F1967377517} # investigation * error message: P1687414110 * code search: https://fburl.com/code/r3euunl4 # changes 1. add `tensordict` to EBC/EC/KJT targets files 2. use a temporary `try import tensordict ... catch ...` logic to import the `tensordict` module safely 3. set `tensordict` as extern module in the fbpackager NOTE: the `try import tensordict...catch...` will be removed in the followup diffs where the `tensordict` module is actually needed. WARNING: This diff also add "tensordict" into fbpackager's extern list, will need to cautiously confirm the change is valid. Reviewed By: dstaay-fb Differential Revision: D66465376 fbshipit-source-id: 39b897e6176ac5ee95e39e8e810644d4f14608a1
- Loading branch information
1 parent
f0768a0
commit af4cb11
Showing
4 changed files
with
28 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters