Skip to content

Commit

Permalink
Add support for Rowwise and Columnwise sharding (#1621)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #1621

Add in Rowwise and Columnwise sharding to inference module benchmarking suite by default.

Reviewed By: bigning

Differential Revision: D52641307

fbshipit-source-id: f396bcfb9ac71fe65906a723184efde547c80235
  • Loading branch information
PaulZhang12 authored and facebook-github-bot committed Jan 10, 2024
1 parent 93de315 commit 10000de
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions torchrec/distributed/benchmark/benchmark_inference.py
Original file line number Diff line number Diff line change
Expand Up @@ -439,11 +439,10 @@ def main() -> None:
# Place all outputs under the datetime folder
os.mkdir(output_dir)

# TODO: ROW_WISE and COLUMN_WISE are not supported yet
BENCH_SHARDING_TYPES = [
ShardingType.TABLE_WISE,
# ShardingType.ROW_WISE,
# ShardingType.COLUMN_WISE,
ShardingType.ROW_WISE,
ShardingType.COLUMN_WISE,
]

table_sizes = [
Expand Down

0 comments on commit 10000de

Please sign in to comment.