Bug fix when torch.load mmap=True #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
mergennachin
changed the title
seemethere
reviewed
Apr 16, 2024
build/builder.py
Outdated
Comment on lines
209
to
211
| path = builder_args.checkpoint_path | ||
| if isinstance(builder_args.checkpoint_path, Path): | ||
| path = str(path) |
There was a problem hiding this comment.
Suggested change
| path = builder_args.checkpoint_path | |
| if isinstance(builder_args.checkpoint_path, Path): | |
| path = str(path) |
There was a problem hiding this comment.
if isinstance(path, Path):
Also I thought that str is demo_potent, so you might just write
path = str(builder_args.checkpoint_path)
15d7834 to
754bca6
Compare
mikekgfb
approved these changes
Apr 16, 2024
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
malfet
pushed a commit
that referenced
this pull request
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently causing this error:
https://www.internalfb.com/phabricator/paste/view/P1215350825
Repro:
https://www.internalfb.com/phabricator/paste/view/P1215351085
After the PR fixes the issue
Test Plan: OSS CI