source instead of exec in run-readme-pr-macos.yml #1476
Conversation
source test commands instead of executing them. (Possible fix for pytorch#1315 )
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/1476
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
source instead of exec
somebody pushed all the model exports into exportedModels, but... we never create the directory. we should do that also do this in the user instructions, just because storing into a directory that doesn't exist is not good :)
|
@Jack-Khuu when it rains it pours, that showed more false positives per #1315 than anybody could anticipate! I added the directory that all the examples use (but don't create!), or we can just removed the directory... |
|
@Jack-Khuu Ideally we start a run for 1476, and in parallel commit 1409, 1410, 1417, 1439, 1455, 1466. PS: In a nutshell, failures for the doc based runs haven't bubbled up because a failure inside a shell script that's executed with bash did not seem to pass failure information to upstream. Using source to run the multiple layers rectifies this, and may be a pragmatic answer to restoring full test coverage. (I think right now we've cought some of the fails that have not bubbled up to hud.pytorch.org because of the exec/bash dichotomy by eye balling which is not a healthy long term solution. |
|
Yup, making my way through those CI PR's then we'll rebase this one Our current coverage has plenty of gaps and has honestly been adhoc, so revamping the CI and creating a comprehensive unittest system is a P0 KR for us this half (working on it with @Gasoonjia). Thanks again for grinding through these!! |
pip3 not found. I guess we do conda for this environment. That's interesting. How do we deal with conda like that. or is it just pip vs pip3. ( https://github.com/pytorch/torchchat/actions/runs/12942557291/job/36137959147?pr=1476 |
multimodal doc needed end of tests comment.
Need to download files before using them, lol. We expect the users to do this, but we should verbalize. Plus, if we extract for testing, then it obviously fails.
( triggers unexpected token in macos zsh
# metadata does not install properly on macos
# .ci/scripts/run-docs multimodal
# metadata does not install properly on macos
# .ci/scripts/run-docs multimodal
|
https://hud.pytorch.org/pr/pytorch/torchchat/1476#36153855033 |
install wget
echo ".ci/scripts/run-docs native DISABLED"
# .ci/scripts/run-docs native
echo ".ci/scripts/run-docs native DISABLED"
# .ci/scripts/run-docs native
source test commands instead of executing them.
(Possible fix for #1315 )