Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate framework changes, intorduce get_stable_cuda.py add py3.13t required changes #6339

Merged
merged 10 commits into from
Feb 26, 2025
Merged

Validate framework changes, intorduce get_stable_cuda.py add py3.13t required changes #6339

merged 10 commits into from
Feb 26, 2025

Conversation

atalman
Copy link
Contributor

@atalman atalman commented Feb 26, 2025 •
edited
Loading

  1. Introduce get_stable_cuda, this way we don't need to hardcode current stable cuda version in validations
  2. Add py3.13t versions

@vercel Vercel
Copy link

vercel bot commented Feb 26, 2025

@atalman is attempting to deploy a commit to the Meta Open Source Team on Vercel.

A member of the Team first needs to authorize it.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 26, 2025
@atalman atalman changed the title Release validations changes for py3.13t and stable cuda Validate framework changes, intorduce get_stable_cuda.py add py3.13t required changes Feb 26, 2025
huydhn
huydhn reviewed Feb 26, 2025
View reviewed changes
.github/workflows/validate-pypi-wheel-binary-size.yml
@@ -32,7 +32,12 @@ jobs:
pip3 install -r tools/binary_size_validation/requirements.txt
- name: Run validation
run: |
# shellcheck disable=SC2086
CUDA_VERSION=$(python3 tools/scripts/get_stable_cuda_version.py --channel ${CHANNEL})
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a thought that I think we could do some bash-fu with jq and sed or something to get the stable CUDA version, but I guess a python script is easier to read :)

@atalman atalman merged commit 607e1b0 into pytorch:main Feb 26, 2025
107 of 116 checks passed
@atalman atalman mentioned this pull request Mar 10, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huydhn huydhn huydhn approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atalman @huydhn @facebook-github-bot