Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SQLFLUFF linter for clickhouse queries #6209

Merged
merged 4 commits into from
Jan 25, 2025
Merged

Add SQLFLUFF linter for clickhouse queries #6209

merged 4 commits into from
Jan 25, 2025

Conversation

Camyll
Copy link
Contributor

@Camyll Camyll commented Jan 22, 2025

add sqlfluff linter using clickhouse dialect on for use on linting clickhouse queries

Copy link

vercel bot commented Jan 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
torchci ⬜️ Ignored (Inspect) Visit Preview Jan 25, 2025 0:07am

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 22, 2025
@Camyll Camyll marked this pull request as ready for review January 24, 2025 19:37
Copy link
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! There is only a minor comment about using a temporary file instead

@huydhn
Copy link
Contributor

huydhn commented Jan 24, 2025

Wait s sec, there is also an error in the lint workflow https://github.com/pytorch/test-infra/actions/runs/12956209088/job/36141963692?pr=6209#step:4:243

@Camyll Camyll merged commit f4c813d into main Jan 25, 2025
8 checks passed
@Camyll Camyll deleted the sqlfluff_linter branch January 25, 2025 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants