Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cuda 12.6 wheels with Manylinux 2.28. Use Manylinux2014 for CPU, CUDA11.8, CUDA12.4 #5986

Merged
merged 3 commits into from
Nov 26, 2024

Conversation

atalman
Copy link
Contributor

@atalman atalman commented Nov 26, 2024

Copy link

vercel bot commented Nov 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
torchci ⬜️ Ignored (Inspect) Visit Preview Nov 26, 2024 6:41pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 26, 2024
@atalman atalman changed the title Use cuda 12.6 wheels with Manylinux 2.28. Use Manylinux2014 for CPU, … Use cuda 12.6 wheels with Manylinux 2.28. Use Manylinux2014 for CPU, CUDA11.8, CUDA12.4 Nov 26, 2024
gpu_arch: f"pytorch/manylinux2_28-builder:cuda{gpu_arch}"
for gpu_arch in CUDA_ARCHES
},
"11.8": f"pytorch/manylinux-builder:cuda11.8",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for f-strings.

Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but can we stop sending identical PRs against PT and than test-infra

@atalman atalman merged commit 8856c07 into main Nov 26, 2024
44 of 60 checks passed
@atalman atalman deleted the atalman-patch-15 branch November 26, 2024 21:20
HDCharles added a commit to pytorch/ao that referenced this pull request Nov 27, 2024
pytorch/test-infra#5986 and pytorch/pytorch#141565 changed back to manylinux 2014 for versions of cuda/cpu, testing that this fixes the issue since hte actual error seems to be occuring in the Build the wheel step before hte post script gets run:

https://github.com/pytorch/ao/actions/runs/12041427944/job/33573281510
atalman pushed a commit that referenced this pull request Nov 27, 2024
… (#5993)

Also adds a way to update the files by just running the test script
through `python -m tools.tests.test_generate_binary_build_matrix
--update-reference-files`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants