-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use cuda 12.6 wheels with Manylinux 2.28. Use Manylinux2014 for CPU, CUDA11.8, CUDA12.4 #5986
Conversation
…CUDA11.8, CUDA12.4
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
gpu_arch: f"pytorch/manylinux2_28-builder:cuda{gpu_arch}" | ||
for gpu_arch in CUDA_ARCHES | ||
}, | ||
"11.8": f"pytorch/manylinux-builder:cuda11.8", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need for f-strings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but can we stop sending identical PRs against PT and than test-infra
pytorch/test-infra#5986 and pytorch/pytorch#141565 changed back to manylinux 2014 for versions of cuda/cpu, testing that this fixes the issue since hte actual error seems to be occuring in the Build the wheel step before hte post script gets run: https://github.com/pytorch/ao/actions/runs/12041427944/job/33573281510
… (#5993) Also adds a way to update the files by just running the test script through `python -m tools.tests.test_generate_binary_build_matrix --update-reference-files`
PyTorch PR: https://github.com/pytorch/pytorch/pull/141565/files