Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Nova callers to choose Python version to build #5981

Merged
merged 6 commits into from
Nov 25, 2024

Conversation

huydhn
Copy link
Contributor

@huydhn huydhn commented Nov 25, 2024

This is a simple tweak to add python-versions to .github/workflows/generate_binary_build_matrix.yml so that Nova caller can narrow down the python version they want to build. While PyTorch supports all Python versions from 3.9 to 3.13, not all domain libraries can do so. So, unsupported Python versions always show up on their nightly branches, for example https://hud.pytorch.org/hud/pytorch/executorch/nightly/1?per_page=50&mergeLF=true.

The rest of the changes are lint fixes.

Testing

@huydhn huydhn requested a review from atalman November 25, 2024 21:46
Copy link

vercel bot commented Nov 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
torchci ⬜️ Ignored (Inspect) Visit Preview Nov 25, 2024 10:45pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 25, 2024
Copy link

pytorch-bot bot commented Nov 25, 2024

No ciflow labels are configured for this repo.
For information on how to enable CIFlow bot see this wiki

Copy link
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@huydhn huydhn merged commit 00739f6 into main Nov 25, 2024
136 of 165 checks passed
@huydhn huydhn deleted the select-python-version-binary-build branch November 25, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants