[Cherry-pick for release/2.5] #5931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR enable the build of M1 wheels to rely on `python -m build` instead of `python setup.py`. The default is still `python setup.py`. This is the same as pytorch#5071 and pytorch#5076 that were landed for linux wheels. We need this for torchcodec to support M1 wheels pytorch/torchcodec#230 CC @scotts @atalman
Currently, building Mac wheels has setting up miniconda for binary builds hard-coded to false. I believe this prevents us from doing wheel building on ephemeral runners. When trying to build Mac wheels on ephemeral runners, we run into a [`conda command not found`](https://github.com/pytorch/torchcodec/actions/runs/11580808748/job/32240163090?pr=320) error. Conda is not found because it's not installed. I assume that on our stable runners, it's already there. This PR adds setting up miniconda as an option. It defaults to `false` because currently everyone is already working without setting it up, so it seems safest to disable it by default. This change mirrors what is currently in building wheels for Linux: https://github.com/pytorch/test-infra/blob/29912dec4567529a8aa7d124b7610c06b1648acb/.github/workflows/build_wheels_linux.yml#L68-L72
|
@scotts is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
facebook-github-bot
added
the
CLA Signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2 cherry-picks below needed for torchcodec.