Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use python3 instead of python for macos wheels build #5737

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

NicolasHug
Copy link
Member

No description provided.

Copy link

vercel bot commented Oct 2, 2024

@NicolasHug is attempting to deploy a commit to the Meta Open Source Team on Vercel.

A member of the Team first needs to authorize it.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 2, 2024
Copy link
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@atalman atalman merged commit 533877f into pytorch:main Oct 2, 2024
9 of 14 checks passed
atalman added a commit that referenced this pull request Oct 9, 2024
atalman added a commit that referenced this pull request Oct 9, 2024
Reverts #5737

This causes issue:
https://github.com/pytorch/torchcodec/actions/runs/11155431850/job/31006353091?pr=230

During build, different Python verison is getting picked up, required
3.9 - version used 3.10:

```
+ __conda_exe run -p /Users/ec2-user/runner/_work/_temp/conda_environment_11155431850 python3 -m pip install build
+ /opt/homebrew/Caskroom/miniconda/base/bin/conda run -p /Users/ec2-user/runner/_work/_temp/conda_environment_11155431850 python3 -m pip install build
  WARNING: The script pyproject-build is installed in '/Library/Frameworks/Python.framework/Versions/3.10/bin' which is not on PATH.
  Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location.

Notice:  A new release of pip is available: 23.0.1 -> 24.2
Notice:  To update, run: python3 -m pip install --upgrade pip

```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants