Fix smoke test path in Windows binary build workflow #5726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chuanqi129 is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
facebook-github-bot
added
the
CLA Signed
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
huydhn
reviewed
Sep 27, 2024
| @@ -202,10 +202,10 @@ jobs: | |||
| ${CONDA_RUN} pip install "${{ inputs.repository }}/dist/$WHEEL_NAME" | |||
| if [[ ! -f "${{ inputs.repository }}"/${SMOKE_TEST_SCRIPT} ]]; then | |||
| echo "${{ inputs.repository }}/${SMOKE_TEST_SCRIPT} not found" | |||
| ${CONDA_RUN} ${ENV_SCRIPT} python -c "import ${PACKAGE_NAME}; print('package version is ', ${PACKAGE_NAME}.__version__)" | |||
| ${CONDA_RUN} "${{ inputs.repository }}/${ENV_SCRIPT}" python -c "import ${PACKAGE_NAME}; print('package version is ', ${PACKAGE_NAME}.__version__)" | |||
There was a problem hiding this comment.
It might be easier to avoid similar mistakes if you can set working-directory: ${{ inputs.repository }} like the previous step
There was a problem hiding this comment.
Thanks @huydhn, agree with you, but I don't have test env in local, so let's fix it firstly with the smallest change and then we can have another enhance PR to simplify the smoke test part. How do you think?
huydhn
approved these changes
Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The smoke test is different with previously steps, which not set working-directory as ${{ inputs.repository }}
Works for pytorch/pytorch#114850