-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add XPU to binary build generation #5489
Conversation
@chuanqi129 is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
@@ -35,6 +35,10 @@ on: | |||
description: "Build with CPU?" | |||
default: "enable" | |||
type: string | |||
with-xpu: | |||
description: "Build with XPU?" | |||
default: "enable" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please keep it disable for now. Since this will automatically enable vision and audio builds. I don't think we want this at this point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @atalman thanks for the review, we plan to enable vision and audio build also for now. So that we can have completed nightly install cmd like pip3 install --pre torch torchvision torchaudio --index-url https://download.pytorch.org/whl/nightly/xpu
. How do you think? Any concern in here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @chuanqi129 please set default to disable since multiple domains use this script. Here are some examples:
https://github.com/pytorch/data/blob/main/.github/workflows/build_wheels_linux.yml#L29
https://github.com/pytorch/torchtune/blob/main/.github/workflows/build_linux_wheels.yaml#L29
https://github.com/pytorch/ao/blob/main/.github/workflows/build_wheels_linux.yml#L30
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, thanks @atalman for the reminder. Got your point now, I will set the with_xpu
disable as default and enable it in torchvision and torchaudio after this PR land, does it make sense to you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, please adress comment of setting with with-xpu to disable by default
Something that was missed by #5489
Torch XPU nightly wheel build has been enabled with #pytorch/pytorch#129560 landed, add XPU to binary build generation. Works for pytorch/pytorch#114850