Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always try to upload artifacts even if Nova jobs fail #5208

Merged
merged 1 commit into from
May 15, 2024

Conversation

huydhn
Copy link
Contributor

@huydhn huydhn commented May 15, 2024

This is reported by @wconstab that Nova jobs didn't upload artifacts to GitHub when the test script failed, so it's not possible to access them, for example, to debug the failure. It makes sense to always try to upload the artifacts instead:

  • If the script fails, but there are artifacts, we should upload them
  • If the script fails, and there is no artifact, it doesn't matter if the upload step fails or not because the job is going to fail anyway

@huydhn huydhn requested review from seemethere and wconstab May 15, 2024 23:20
Copy link

vercel bot commented May 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
torchci ⬜️ Ignored (Inspect) May 15, 2024 11:20pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 15, 2024
@huydhn huydhn requested a review from a team May 15, 2024 23:25
@huydhn huydhn merged commit 8f7a4bd into main May 15, 2024
30 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants