Correctly checkout test-infra on Nova _binary_upload job #4882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
atalman
approved these changes
Jan 15, 2024
huydhn
added a commit
that referenced
this pull request
Feb 12, 2024
I made a mistake in #4877 when not explicitly select `test-infra` as the repo to checkout for the GHA. When running on domains, the default repos are domains, i.e. `pytorch/vision`, and they don't have the GHA we need, namely `setup-binary-upload`. An example failure when testing on vision nightly https://github.com/pytorch/vision/actions/runs/7533535440/job/20506343331
This was referenced Feb 12, 2024
huydhn
added a commit
that referenced
this pull request
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a mistake in #4877 when not explicitly select
test-infraas the repo to checkout for the GHA. When running on domains, the default repos are domains, i.e.pytorch/vision, and they don't have the GHA we need, namelysetup-binary-upload.An example failure when testing on vision nightly https://github.com/pytorch/vision/actions/runs/7533535440/job/20506343331