Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the label for the macOS runners #4863

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

DanilBaibak
Copy link
Contributor

Changed the label for the macOS runners to macos-m1-stable.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 10, 2024
Copy link

vercel bot commented Jan 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
torchci ✅ Ready (Inspect) Visit Preview Jan 10, 2024 1:47pm

Copy link
Contributor

@jeanschmidt jeanschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets discuss and and solve the macos-12 runner label. If it is running the latest mac release, such as macos-m1-12 maybe we want to migrate both in order to have a more stable naming.

It is better to have a bad standard than no standard at all.

so lets wait to understand this a bit better and see if we can have a direction before moving forward.

@malfet
Copy link
Contributor

malfet commented Jan 16, 2024

Lets discuss and and solve the macos-12 runner label. If it is running the latest mac release, such as macos-m1-12 maybe we want to migrate both in order to have a more stable naming.

macos-m1-12 is currently huge misnomer, as it actually allocates the runners with MacOS13.3 , while latest is already MacOS14.2

IMO latest label is OK as it follows GitHub convetion, but stable might be a bit controversial. It would be ideal, if we can maintain macos-m1-12, macos-m1-13 and mcaos-m1-14 proper label, but have an easy mechanism for specifying how many runners of each type we want to have in the system

@DanilBaibak DanilBaibak merged commit 5469643 into main Jan 17, 2024
105 checks passed
@DanilBaibak DanilBaibak deleted the Switch-Label-for-macOS-Runners branch January 17, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants