Reland "DO NOT REVERT - Updating workflows to gather AWS authentication via OIDC" #4786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
facebook-github-bot
added
the
CLA Signed
|
@jeanschmidt Please don't land this PR until we fix all Binary test builds. |
jeanschmidt
deleted the
revert-4785-revert-4751-jeanschmidt/oidc_aws_auth
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #4785
Relands #4751
Updates actions that integrate with AWS to authenticate using OIDC roles over users keys.
For all workflow owners/developers:
Please test your workflow to make sure it is working and it is mergeable, I have to merge this anyways so it is interesting to give this task a high priority. I can't properly manage the scale of workflows and figure out all the permissions by trial-and-error.
If you need to submit fixes for this PR, feel free to do so. Very likely you will have to update the permissions provided for the roles that are assigned for the workflows: https://github.com/pytorch-labs/pytorch-gha-infra/pull/285
You can do so by opening a PR, merging and rolling it out.
There is a doc here explaining the (very straightforward) process: https://docs.google.com/document/d/1IMAGE9RMIcZBcTaEeTOivySJZpE74bq5IJAwzdlxxfw/edit?usp=sharing