Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Nova] Do not install conda-build for wheels #4774

Merged
merged 2 commits into from
Dec 1, 2023
Merged

[Nova] Do not install conda-build for wheels #4774

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f88d186
[Nova] Do not install conda-build for wheels
malfet Nov 30, 2023
2ff5f25
Should not be escaped
malfet Dec 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions .github/actions/setup-binary-builds/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,16 +108,23 @@ runs:
run: |
set -euxo pipefail
CONDA_ENV="${RUNNER_TEMP}/conda_environment_${GITHUB_RUN_ID}"
if [[ "${PACKAGE_TYPE:-}" == "conda" ]]; then
# For conda package host python version is irrelevant
export PYTHON_VERSION=3.9
export CONDA_BUILD_EXTRA="conda=23.10.0 conda-build=3.27.0"
else
# For wheel builds we don't need neither conda nor conda-build
export CONDA_BUILD_EXTRA=""
fi

conda create \
--yes --quiet \
--prefix "${CONDA_ENV}" \
"python=${PYTHON_VERSION}" \
cmake=3.22 \
conda-build=3.27.0 \
conda=23.10.0 \
ninja=1.10 \
pkg-config=0.29 \
${CONDA_BUILD_EXTRA} \
wheel=0.37

echo "CONDA_ENV=${CONDA_ENV}" >> "${GITHUB_ENV}"
Expand Down
Loading