Remove distr prefix from macos builds #4766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@atalman is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
facebook-github-bot
added
the
CLA Signed
atalman
force-pushed
the
m1_builds_conda
branch
from
a8b07bc to
ddb27f5
Compare
atalman
changed the title
osalpekar
approved these changes
Nov 29, 2023
atalman
added a commit
to atalman/test-infra
that referenced
this pull request
Nov 29, 2023
MacOS smoke test started to fail with following error: ``` /opt/homebrew/Caskroom/miniconda/base/bin/conda run -p /Users/ec2-user/runner/_work/_temp/pytorch_pkg_helpers_7018156083_smoke conda install --quiet --yes -c pytorch-nightly -c file:///Users/ec2-user/runner/_work/vision/vision/pytorch/vision/distr distr::torchvision PackagesNotFoundError: The following packages are not available from current channels: - distr::torchvision Current channels: - https://conda.anaconda.org/pytorch-nightly - file:///Users/ec2-user/runner/_work/vision/vision/pytorch/vision/distr - defaults - https://conda.anaconda.org/distr <-- Here is the error To search for alternate channels that may provide the conda package you're looking for, navigate to https://anaconda.org/ and use the search bar at the top of the page. ``` Hence removing distr channel produces expected result. Please note: followup may be required to make sure file is actually installed from expected: `` file:///Users/ec2-user/runner/_work/vision/vision/pytorch/vision/distr `` and not ``pytorch-nightly`` or ``pytorch-test``
atalman
added a commit
that referenced
this pull request
Nov 29, 2023
MacOS smoke test started to fail with following error: ``` /opt/homebrew/Caskroom/miniconda/base/bin/conda run -p /Users/ec2-user/runner/_work/_temp/pytorch_pkg_helpers_7018156083_smoke conda install --quiet --yes -c pytorch-nightly -c file:///Users/ec2-user/runner/_work/vision/vision/pytorch/vision/distr distr::torchvision PackagesNotFoundError: The following packages are not available from current channels: - distr::torchvision Current channels: - https://conda.anaconda.org/pytorch-nightly - file:///Users/ec2-user/runner/_work/vision/vision/pytorch/vision/distr - defaults - https://conda.anaconda.org/distr <-- Here is the error To search for alternate channels that may provide the conda package you're looking for, navigate to https://anaconda.org/ and use the search bar at the top of the page. ``` Hence removing distr channel produces expected result. Please note: followup may be required to make sure file is actually installed from expected: `` file:///Users/ec2-user/runner/_work/vision/vision/pytorch/vision/distr `` and not ``pytorch-nightly`` or ``pytorch-test``
|
Please revert this change and file a bug against conda, as they should support local changes (or perhaps the syntax have changed) |
atalman
added a commit
that referenced
this pull request
Nov 30, 2023
…l. (#4770) Forward fix for: #4766 Related to issue: https://github.com/conda/conda/issues/13374 1. Make sure packages are searched in particular order during install. Use override-channel option when installing packages for smoke test: From Conda documentation: https://docs.conda.io/projects/conda/en/latest/user-guide/concepts/channels.html#specifying-channels-when-installing-packages ``` From the command line use --c You may specify multiple channels by passing the argument multiple times. Priority decreases from left to right - the first argument is higher priority than the second. From the command line use --override-channels to only search the specified channel(s), rather than any channels configured in .condarc. ``` 2. Add check for validating that required package is actually installed from required channel
atalman
added a commit
to atalman/test-infra
that referenced
this pull request
Nov 30, 2023
…l. (pytorch#4770) Forward fix for: pytorch#4766 Related to issue: https://github.com/conda/conda/issues/13374 1. Make sure packages are searched in particular order during install. Use override-channel option when installing packages for smoke test: From Conda documentation: https://docs.conda.io/projects/conda/en/latest/user-guide/concepts/channels.html#specifying-channels-when-installing-packages ``` From the command line use --c You may specify multiple channels by passing the argument multiple times. Priority decreases from left to right - the first argument is higher priority than the second. From the command line use --override-channels to only search the specified channel(s), rather than any channels configured in .condarc. ``` 2. Add check for validating that required package is actually installed from required channel
atalman
added a commit
that referenced
this pull request
Nov 30, 2023
#4771) Forward fix for: #4766 Related to issue: https://github.com/conda/conda/issues/13374 1. Make sure packages are searched in particular order during install. Use override-channel option when installing packages for smoke test: From Conda documentation: https://docs.conda.io/projects/conda/en/latest/user-guide/concepts/channels.html#specifying-channels-when-installing-packages ``` From the command line use --c You may specify multiple channels by passing the argument multiple times. Priority decreases from left to right - the first argument is higher priority than the second. From the command line use --override-channels to only search the specified channel(s), rather than any channels configured in .condarc. ``` 2. Add check for validating that required package is actually installed from required channel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MacOS smoke test started to fail with following error:
Hence removing distr channel produces expected result.
Please note: followup may be required to make sure file is actually installed from expected:
file:///Users/ec2-user/runner/_work/vision/vision/pytorch/vision/distrand not
pytorch-nightlyorpytorch-test