Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better libtorch definitions for test channel #4720

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

malfet
Copy link
Contributor

@malfet malfet commented Nov 9, 2023

We should be testing particular version rather than latest

% python tools/scripts/generate_binary_build_matrix.py --operating-system macos --channel test --package-type libtorch|jq
{
  "include": [
    {
      "gpu_arch_type": "cpu",
      "gpu_arch_version": "",
      "desired_cuda": "cpu",
      "libtorch_variant": "shared-with-deps",
      "libtorch_config": "",
      "devtoolset": "cxx11-abi",
      "container_image": "pytorch/libtorch-cxx11-builder:cpu",
      "package_type": "libtorch",
      "build_name": "libtorch-cpu-shared-with-deps-cxx11-abi",
      "validation_runner": "macos-12",
      "installation": "https://download.pytorch.org/libtorch/test/cpu/libtorch-macos-2.1.1.zip",
      "channel": "test",
      "stable_version": "2.1.1"
    }
  ]
}

We should be testing particular version rather than latest
```
% python tools/scripts/generate_binary_build_matrix.py --operating-system macos --channel test --package-type libtorch|jq
{
  "include": [
    {
      "gpu_arch_type": "cpu",
      "gpu_arch_version": "",
      "desired_cuda": "cpu",
      "libtorch_variant": "shared-with-deps",
      "libtorch_config": "",
      "devtoolset": "cxx11-abi",
      "container_image": "pytorch/libtorch-cxx11-builder:cpu",
      "package_type": "libtorch",
      "build_name": "libtorch-cpu-shared-with-deps-cxx11-abi",
      "validation_runner": "macos-12",
      "installation": "https://download.pytorch.org/libtorch/test/cpu/libtorch-macos-2.1.1.zip",
      "channel": "test",
      "stable_version": "2.1.1"
    }
  ]
}
```
Copy link

vercel bot commented Nov 9, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
torchci ⬜️ Ignored (Inspect) Visit Preview Nov 9, 2023 6:37pm

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 9, 2023
@malfet malfet merged commit e900ee1 into main Nov 9, 2023
58 of 66 checks passed
@malfet malfet deleted the malfet/better-libtorch-test branch November 9, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants