upload classification results to rockset with metadata #4640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 14, 2023
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
facebook-github-bot
added
the
CLA Signed
PaliC
force-pushed
the
pr4640
branch
2 times, most recently
from
f78323d to
ccc31c9
Compare
PaliC
added a commit
that referenced
this pull request
Oct 17, 2023
add ability to view multiple focused log lines at once Add view of multiple lines using rockset. Currently we just show the same error line (because there is only one in rockset). Currently, this is also hidden under a feature flag. <img width="915" alt="Screenshot 2023-10-13 at 2 28 46 PM" src="https://github.com/pytorch/test-infra/assets/13758638/4652e132-6886-4c21-9ac4-f208cc4d1edd"> <!-- copilot:summary --> ### <samp>🤖 Generated by Copilot at a80550d</samp> This pull request adds the log annotation feature to the test-infra web app, which allows users to rate the quality of the log output for a job and to see multiple failure lines for a job. It also updates the backend SQL queries and the frontend components to handle the new failureLines and failureLineNumbers properties for jobs, and fixes some minor issues in the code. The affected files include `JobLinks.tsx`, `LogViewer.tsx`, `LogAnnotationToggle.tsx`, `types.ts`, `drciUtils.ts`, `searchUtils.ts`, `log_annotation/[repoOwner]/[repoName]/[annotation].ts`, `metrics.tsx`, and several files in the `rockset` folder. --- Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/pytorch/test-infra/pull/4637). * #4640 * #4639 * __->__ #4637 Co-authored-by: PaliC <>
Closed
PaliC
force-pushed
the
pr4640
branch
2 times, most recently
from
a7ccc1b to
76839d5
Compare
PaliC
force-pushed
the
pr4640
branch
3 times, most recently
from
dbdb799 to
b29256b
Compare
PaliC
added a commit
that referenced
this pull request
Oct 18, 2023
[reland] add ability to view multiple focused log lines at once add ability to view multiple focused log lines at once Add view of multiple lines using rockset. Currently we just show the same error line (because there is only one in rockset). Currently, this is also hidden under a feature flag. <img width="915" alt="Screenshot 2023-10-13 at 2 28 46 PM" src="https://github.com/pytorch/test-infra/assets/13758638/4652e132-6886-4c21-9ac4-f208cc4d1edd"> <!-- copilot:summary --> ### <samp>🤖 Generated by Copilot at a80550d</samp> This pull request adds the log annotation feature to the test-infra web app, which allows users to rate the quality of the log output for a job and to see multiple failure lines for a job. It also updates the backend SQL queries and the frontend components to handle the new failureLines and failureLineNumbers properties for jobs, and fixes some minor issues in the code. The affected files include `JobLinks.tsx`, `LogViewer.tsx`, `LogAnnotationToggle.tsx`, `types.ts`, `drciUtils.ts`, `searchUtils.ts`, `log_annotation/[repoOwner]/[repoName]/[annotation].ts`, `metrics.tsx`, and several files in the `rockset` folder. Original commit changeset: 3b5dd27 --- Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/pytorch/test-infra/pull/4657). * #4640 * #4639 * __->__ #4657 Co-authored-by: PaliC <>
PaliC
changed the title
PaliC
force-pushed
the
pr4640
branch
2 times, most recently
from
a5711e4 to
95c5eb6
Compare
PaliC
force-pushed
the
pr4640
branch
3 times, most recently
from
52f271e to
41a9e9b
Compare
added 3 commits
October 19, 2023 14:03
Adds a log classification rule + testing to classify log lines based on their position. A follow up pr will link this to rockset
copilot:summary
PaliC
added a commit
that referenced
this pull request
Oct 19, 2023
… on… (#4659)" (#4660) "[reland] [reland] add ability to view multiple focused log lines at on… (#4659)" Original commit changeset: 06978f0 I'm reasonably confident this works now, though can someone confirm through checking on Vercel --- Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/pytorch/test-infra/pull/4660). * #4640 * #4639 * __->__ #4660 Co-authored-by: PaliC <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
upload classification results to rockset with metadata
🤖 Generated by Copilot at c810506
No summary available (Limit exceeded: required to process 77150 tokens, but only 50000 are allowed per call)
Stack created with Sapling. Best reviewed with ReviewStack.