add buttons to rate logs #4629
Merged
add buttons to rate logs #4629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
Adds buttons hidden under a feature flag which gives us the ability to rate logs <img width="1444" alt="Screenshot 2023-10-11 at 4 55 55 PM" src="https://github.com/pytorch/test-infra/assets/13758638/76748be5-44f7-4e51-8e72-d781a96e9ba3"> <!-- copilot:summary --> ### <samp>🤖 Generated by Copilot at e97f54f</samp> This pull request adds the feature to annotate the log rating of a job in the `LogViewer` component. It introduces a new component `LogAnnotationToggle` that allows users to select an annotation and sends it to a new API handler `/api/log_annotation`. It also defines a new type `LogAnnotation` and stores the annotation data in a DynamoDB table.
huydhn
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add buttons to rate logs
Adds buttons hidden under a feature flag which gives us the ability to rate logs
🤖 Generated by Copilot at e97f54f
This pull request adds the feature to annotate the log rating of a job in the
LogViewercomponent. It introduces a new componentLogAnnotationTogglethat allows users to select an annotation and sends it to a new API handler/api/log_annotation. It also defines a new typeLogAnnotationand stores the annotation data in a DynamoDB table.Stack created with Sapling. Best reviewed with ReviewStack.