Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Pin conda build images - fix nightly conda failures (#4582)" #4606

Merged
merged 2 commits into from
Oct 11, 2023

Conversation

atalman
Copy link
Contributor

@atalman atalman commented Oct 2, 2023

This

  1. reverts commit 389b0ab.
  2. fixes issue with conda picking up default test env created by: https://github.com/conda-incubator/setup-miniconda#conda-incubatorsetup-miniconda
    That forced us to do docker pin.
    Here is the failure:
    https://github.com/pytorch/test-infra/actions/runs/6474243290/job/17578773829?pr=4606#step:10:1113

Root Cause: conda is picking test environment by default rather then $CONDA_ENV for building the package

++++ __conda_exe shell.posix activate base
++++ /opt/conda/bin/conda shell.posix activate base
+++ ask_conda='export PATH='\''/opt/conda/conda-bld/torchvision_1696968398076/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeh:/opt/conda/conda-bld/torchvision_1696968398076/_test_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeh/bin:/opt/conda/bin:/opt/conda/condabin:3/condabin:/opt/conda/bin:/opt/rh/devtoolset-9/root/usr/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin'\''
  1. Removes python 3.11 case, since conda is fully supporting python 3.11 now

@vercel
Copy link

vercel bot commented Oct 2, 2023

@atalman is attempting to deploy a commit to the Meta Open Source Team on Vercel.

A member of the Team first needs to authorize it.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 2, 2023
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds OK, but would be nice to have a more detailed write-up explaining why pining was necessary and why we want to remove it right now. Isn't it better to keep the build system pinned.

@atalman: Point 2 was the cause of pinning. For release builds I agree we should use pinned images. For build system not so sure since all our CI depend on these docker builds that are updated regularly. If we stop using latest images it maybe harder to update later.

…4582)"

This reverts commit 389b0ab.

Add ssh to linux job

Add debug flag

test

test

test

test

test

test

test

test

test

test
@atalman atalman merged commit 1d18e97 into pytorch:main Oct 11, 2023
@henrylhtsang
Copy link

@atalman I think this pr is causing some torchrec python 3.11 build-linux-wheels tests to fail.

11 hours, tests passing
https://github.com/pytorch/torchrec/actions/runs/6483145174

6 hours ago, python 3.11 failing
https://github.com/pytorch/torchrec/actions/runs/6486263265

Also, when I run conda create -n test --yes --quiet python=3.11 cmake=3.22 conda-build=3.21 ninja=1.10 pkg-config=0.29 wheel=0.37 locally, it gives similar errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. with-ssh
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants