Skip to content

Commit

Permalink
Add inputs.delocate-wheel to build_wheels_macos.yaml (#5107)
Browse files Browse the repository at this point in the history
Give clients a way to disable wheel delocation.

This step is only run on macOS, so there's no equivalent change
necessary in the linux or windows workflows.


https://github.com/pytorch/executorch/actions/runs/8759506663/job/24042678714?pr=3049
is an example run using a forked copy of this file (see
pytorch/executorch@aca550b).
It successfully skips the "Install delocate-wheel" and "Delocate wheel"
steps.

While on the testing for this PR, both of those steps run by default:
https://github.com/pytorch/test-infra/actions/runs/8759967852/job/24044074480?pr=5107
  • Loading branch information
dbort authored Apr 20, 2024
1 parent e1466a6 commit f2f9a0e
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions .github/workflows/build_wheels_macos.yml
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,11 @@ on:
required: false
type: string
default: recursive
delocate-wheel:
description: "Whether to run delocate-wheel after building."
required: false
type: boolean
default: true

permissions:
id-token: write
Expand Down Expand Up @@ -121,6 +126,7 @@ jobs:
run: |
cat "${{ inputs.env-var-script }}" >> "${BUILD_ENV_FILE}"
- name: Install delocate-wheel
if: ${{ inputs.delocate-wheel }}
run: |
set -euxo pipefail
${CONDA_RUN} python3 -m pip install delocate==0.10.7
Expand Down Expand Up @@ -161,6 +167,7 @@ jobs:
${CONDA_RUN} python3 setup.py bdist_wheel
- name: Delocate wheel
if: ${{ inputs.delocate-wheel }}
working-directory: ${{ inputs.repository }}
run: |
set -euxo pipefail
Expand Down

0 comments on commit f2f9a0e

Please sign in to comment.