Skip to content

Commit

Permalink
Correctly checkout test-infra on Nova _binary_upload job
Browse files Browse the repository at this point in the history
  • Loading branch information
huydhn committed Jan 15, 2024
1 parent afb5c38 commit eb73a5e
Show file tree
Hide file tree
Showing 4 changed files with 20 additions and 2 deletions.
16 changes: 14 additions & 2 deletions .github/workflows/_binary_upload.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,14 @@ on:
description: 'Reference to checkout, defaults to "nightly"'
default: 'nightly'
type: string
test-infra-repository:
description: "Test infra repository to use"
default: "pytorch/test-infra"
type: string
test-infra-ref:
description: "Test infra reference to use"
default: ""
type: string
build-matrix:
description: "Build matrix to utilize"
default: ''
Expand All @@ -36,9 +44,13 @@ jobs:
name: ${{ matrix.build_name }}
steps:
- uses: actions/checkout@v3
with:
repository: ${{ inputs.test-infra-repository }}
ref: ${{ inputs.test-infra-ref }}
path: test-infra

# For pytorch_pkg_helpers which we need to run to generate the artifact name and target S3 buckets
- uses: ./.github/actions/setup-binary-upload
- uses: ./test-infra/.github/actions/setup-binary-upload
with:
repository: ${{ inputs.repository }}
ref: ${{ inputs.ref }}
Expand All @@ -47,7 +59,7 @@ jobs:
arch: ${{ inputs.architecture }}
upload-to-base-bucket: ${{ matrix.upload_to_base_bucket }}

- uses: ./.github/actions/set-channel
- uses: ./test-infra/.github/actions/set-channel

- name: Download the artifact
uses: actions/download-artifact@v3
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/build_wheels_linux.yml
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,8 @@ jobs:
with:
repository: ${{ inputs.repository }}
ref: ${{ inputs.ref }}
test-infra-repository: ${{ inputs.test-infra-repository }}
test-infra-ref: ${{ inputs.test-infra-ref }}
build-matrix: ${{ inputs.build-matrix }}
architecture: ${{ inputs.architecture }}
trigger-event: ${{ inputs.trigger-event }}
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/build_wheels_macos.yml
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,8 @@ jobs:
with:
repository: ${{ inputs.repository }}
ref: ${{ inputs.ref }}
test-infra-repository: ${{ inputs.test-infra-repository }}
test-infra-ref: ${{ inputs.test-infra-ref }}
build-matrix: ${{ inputs.build-matrix }}
trigger-event: ${{ inputs.trigger-event }}

Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/build_wheels_windows.yml
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,8 @@ jobs:
with:
repository: ${{ inputs.repository }}
ref: ${{ inputs.ref }}
test-infra-repository: ${{ inputs.test-infra-repository }}
test-infra-ref: ${{ inputs.test-infra-ref }}
build-matrix: ${{ inputs.build-matrix }}
trigger-event: ${{ inputs.trigger-event }}

Expand Down

0 comments on commit eb73a5e

Please sign in to comment.