Skip to content

Commit

Permalink
Validate Manylinux 2.28 builds using almalinux-builder image (#6303)
Browse files Browse the repository at this point in the history
For release 2.6 we restricted Manylinux 2.28 builds to cuda 12.6 only.
Now its time to remove this restriction and use cxx11-abi=1 by default
  • Loading branch information
atalman authored Feb 20, 2025
1 parent 5de69da commit e1eabf9
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 8 deletions.
11 changes: 4 additions & 7 deletions .github/scripts/validate_binaries.sh
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
SCRIPT_DIR=$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )
export DESIRED_DEVTOOLSET="cxx11-abi"

if [[ ${MATRIX_PACKAGE_TYPE} == "libtorch" ]]; then
curl ${MATRIX_INSTALLATION} -o libtorch.zip
Expand Down Expand Up @@ -78,13 +79,9 @@ else

pushd ${PWD}/.ci/pytorch/

if [[ ${MATRIX_GPU_ARCH_VERSION} == "12.6" || ${MATRIX_GPU_ARCH_TYPE} == "xpu" || ${MATRIX_GPU_ARCH_TYPE} == "rocm" ]]; then
export DESIRED_DEVTOOLSET="cxx11-abi"

# TODO: enable torch-compile on ROCM
if [[ ${MATRIX_GPU_ARCH_TYPE} == "rocm" ]]; then
TEST_SUFFIX=${TEST_SUFFIX}" --torch-compile-check disabled"
fi
# TODO: enable torch-compile on ROCM
if [[ ${MATRIX_GPU_ARCH_TYPE} == "rocm" ]]; then
TEST_SUFFIX=${TEST_SUFFIX}" --torch-compile-check disabled"
fi

if [[ ${TARGET_OS} == 'linux' ]]; then
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/validate-linux-binaries.yml
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ jobs:
repository: "pytorch/pytorch"
ref: main
job-name: ${{ matrix.build_name }}
docker-image: ${{ ((matrix.gpu_arch_type == 'xpu' || matrix.gpu_arch_type == 'rocm') && matrix.container_image) || (matrix.gpu_arch_version == '12.6' && 'pytorch/almalinux-builder:cpu-main') || 'pytorch/conda-builder' }}
docker-image: ${{ ((matrix.gpu_arch_type == 'xpu' || matrix.gpu_arch_type == 'rocm') && matrix.container_image) || 'pytorch/almalinux-builder:cpu-main' }}
binary-matrix: ${{ toJSON(matrix) }}
docker-build-dir: "skip-docker-build"
timeout: 180
Expand Down

0 comments on commit e1eabf9

Please sign in to comment.