Skip to content

Commit

Permalink
[torchao] Fix torchao GraphPanel (#5302)
Browse files Browse the repository at this point in the history
- Remove the incorrect HTTP request to compiler_benchmark_performance
- Fix the GraphPanel on the summary page.
  • Loading branch information
xuzhao9 authored Jun 6, 2024
1 parent 270b951 commit b4172e5
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 1 deletion.
6 changes: 5 additions & 1 deletion torchci/components/benchmark/compilers/SummaryGraphPanel.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,15 @@ import useSWR from "swr";
const GRAPH_ROW_HEIGHT = 245;

export function GraphPanel({
queryName,
queryParams,
granularity,
suite,
branch,
lCommit,
rCommit,
}: {
queryName: string;
queryParams: RocksetParam[];
granularity: Granularity;
suite: string;
Expand All @@ -41,6 +43,7 @@ export function GraphPanel({
// from Rockset small enough (<6MB) to fit into Vercel lambda limit
return (
<SuiteGraphPanel
queryName={queryName}
queryParams={queryParams}
granularity={granularity}
suite={suite}
Expand All @@ -52,13 +55,15 @@ export function GraphPanel({
}

function SuiteGraphPanel({
queryName,
queryParams,
granularity,
suite,
branch,
lCommit,
rCommit,
}: {
queryName: string;
queryParams: RocksetParam[];
granularity: Granularity;
suite: string;
Expand All @@ -67,7 +72,6 @@ function SuiteGraphPanel({
rCommit: string;
}) {
const queryCollection = "inductor";
const queryName = "compilers_benchmark_performance";

const queryParamsWithSuite: RocksetParam[] = [
{
Expand Down
1 change: 1 addition & 0 deletions torchci/pages/benchmark/compilers.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,7 @@ function Report({
all_suites={SUITES}
/>
<GraphPanel
queryName={"compilers_benchmark_performance"}
queryParams={queryParams}
granularity={granularity}
suite={suite}
Expand Down
1 change: 1 addition & 0 deletions torchci/pages/benchmark/torchao.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,7 @@ function Report({
all_suites={SUITES}
/>
<GraphPanel
queryName={"torchao_query"}
queryParams={queryParams}
granularity={granularity}
suite={suite}
Expand Down

0 comments on commit b4172e5

Please sign in to comment.