Skip to content

Commit

Permalink
Better libtorch definitions for test channel
Browse files Browse the repository at this point in the history
We should be testing particular version rather than latest
```
% python tools/scripts/generate_binary_build_matrix.py --operating-system macos --channel test --package-type libtorch|jq
{
  "include": [
    {
      "gpu_arch_type": "cpu",
      "gpu_arch_version": "",
      "desired_cuda": "cpu",
      "libtorch_variant": "shared-with-deps",
      "libtorch_config": "",
      "devtoolset": "cxx11-abi",
      "container_image": "pytorch/libtorch-cxx11-builder:cpu",
      "package_type": "libtorch",
      "build_name": "libtorch-cpu-shared-with-deps-cxx11-abi",
      "validation_runner": "macos-12",
      "installation": "https://download.pytorch.org/libtorch/test/cpu/libtorch-macos-2.1.1.zip",
      "channel": "test",
      "stable_version": "2.1.1"
    }
  ]
}
```
  • Loading branch information
malfet committed Nov 9, 2023
1 parent b21ac01 commit 0c8a3c9
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions tools/scripts/generate_binary_build_matrix.py
Original file line number Diff line number Diff line change
Expand Up @@ -238,11 +238,8 @@ def get_libtorch_install_command(
if os in [MACOS, MACOS_ARM64]:
arch = "x86_64" if os == MACOS else "arm64"
build_name = f"libtorch-macos-{arch}-latest.zip"
if channel == RELEASE:
if channel in [RELEASE, TEST]:
build_name = f"libtorch-macos-{mod.CURRENT_VERSION}.zip"
# Please note this is temporary, to be removed when doing branch cut for 2.2 release
elif channel == TEST:
build_name = "libtorch-macos-latest.zip"

elif os == LINUX and (channel == RELEASE or channel == TEST):
build_name = (
Expand Down

0 comments on commit 0c8a3c9

Please sign in to comment.