Added python 3.12 dependency in CI (#3219)

* Fix for v5 labeler * Fix for v5 labeler * test for v5 fix * testing new pr labeler workflow * testing new pr labeler workflow * testing new pr labeler workflow * renamed pr-labeler-config to labeler for v5 * Update triage.yml * Update triage.yml * Update triage.yml * Update triage.yml * Rename labeler.yml to pr-labeler-config.yml * Update triage.yml * Update triage.yml * added python 3.12 dependency in CI * added python 3.12 dependency in CI * Delete .vscode/settings.json * Update requirements-dev.txt --------- Co-authored-by: Avinash Sharma <[email protected]> Co-authored-by: vfdev <[email protected]> Co-authored-by: avinashsharma080 <[email protected]>
pytorch · Mar 26, 2024 · 42c4d29 · 42c4d29
1 parent a7246e1
commit 42c4d29
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/.github/workflows/unit-tests.yml b/.github/workflows/unit-tests.yml
@@ -40,7 +40,7 @@ jobs:
       fail-fast: false
       matrix:
         os: [ubuntu-latest]
-        python-version: [3.8, 3.9, "3.10", "3.11"]
+        python-version: ["3.8", "3.9", "3.10", "3.11","3.12"]
         pytorch-channel: [pytorch, pytorch-nightly]
         include:
           # includes a single build on windows

diff --git a/examples/mnist/mnist.py b/examples/mnist/mnist.py
@@ -96,7 +96,7 @@ def log_validation_results(engine):
 
     @trainer.on(Events.EPOCH_COMPLETED | Events.COMPLETED)
     def log_time(engine):
-        tqdm.write(f"{trainer.last_event_name.name} took { trainer.state.times[trainer.last_event_name.name]} seconds")
+        tqdm.write(f"{trainer.last_event_name.name} took {trainer.state.times[trainer.last_event_name.name]} seconds")
 
     trainer.run(train_loader, max_epochs=epochs)
     pbar.close()

diff --git a/requirements-dev.txt b/requirements-dev.txt
@@ -23,7 +23,9 @@ pynvml
 clearml
 scikit-image
 py-rouge
-nltk
+# temporary fix for python=3.12 and v3.8.1
+# nltk
+git+https://github.com/nltk/nltk
 # Examples dependencies
 pandas
 gymnasium