Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arm backend: Add FuseEqualPlaceholdersPass #9893

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

AdrianLundell
Copy link
Collaborator

@AdrianLundell AdrianLundell commented Apr 4, 2025

This pass optimizes memory usage by finding constant placeholders pointing to identical tensors and fusing them to one single placeholder with multiple users.

Note that Ethos-U Vela is updated to include a bug fix related to shared buffers.

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

This pass optimizes memory usage by finding constant placeholders
pointing to identical tensors and fusing them to one single placeholder
with multiple users.

Change-Id: Ia125e120b9ba5acb6e91b2e671e6116a0beebaba
Signed-off-by: Adrian Lundell <[email protected]>
Copy link

pytorch-bot bot commented Apr 4, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/9893

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 5e2dbe5 with merge base 4717459 (image):

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 4, 2025
@zingo zingo added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk labels Apr 4, 2025
@zingo
Copy link
Collaborator

zingo commented Apr 4, 2025

qnn fails are unrelated

@@ -61,7 +61,7 @@ tosa_reference_model_rev="70ed0b40fa831387e36abdb4f7fb9670a3464f5a"

# vela
vela_repo_url="https://gitlab.arm.com/artificial-intelligence/ethos-u/ethos-u-vela"
vela_rev="425541302c7e4b6fbeca7c0061286b131ee507c3"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the heads up @zingo / @AdrianLundell . I think we will pull this one in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants