Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gh/lucylq/28/orig #7844

Closed
wants to merge 3 commits into from
Closed

Gh/lucylq/28/orig #7844

wants to merge 3 commits into from

Conversation

lucylq
Copy link
Contributor

@lucylq lucylq commented Jan 22, 2025

Summary

[PLEASE REMOVE] See CONTRIBUTING.md's Pull Requests for ExecuTorch PR guidelines.

[PLEASE REMOVE] If this PR closes an issue, please add a Fixes #<issue-id> line.

[PLEASE REMOVE] If this PR introduces a fix or feature that should be the upcoming release notes, please add a "Release notes: " label. For a list of available release notes labels, check out CONTRIBUTING.md's Pull Requests.

Test plan

[PLEASE REMOVE] How did you test this PR? Please write down any manual commands you used and note down tests that you have written if applicable.

Pull Request resolved: #7269

Introduce _convert_to_flat_tensor, which interprets a flat_tensor blob as a flat_tensor schema.

Use this for more comprehensive testing for flat tensor serialization, and later for deserialization.

ghstack-source-id: 261976100
@exported-using-ghexport

Differential Revision: [D67007821](https://our.internmc.facebook.com/intern/diff/D67007821/)
Pull Request resolved: #7270

Introduce top-level serialization file that calls:
- serialize_pte_binary for PTE file
- FlatTensor.serialize_tensors for PTD files.


ghstack-source-id: 262004271
@exported-using-ghexport

Differential Revision: [D66523267](https://our.internmc.facebook.com/intern/diff/D66523267/)
Introduce TensorLayout class, used to describe external tensors. Currently contains:
- scalar_type
- sizes
- dim_order

Differential Revision: [D67048723](https://our.internmc.facebook.com/intern/diff/D67048723/)

ghstack-source-id: 262004745
Pull Request resolved: #7761
Copy link

pytorch-bot bot commented Jan 22, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7844

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 22, 2025
Copy link

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@lucylq
Copy link
Contributor Author

lucylq commented Jan 22, 2025

Fix-up here: #7845

@lucylq lucylq closed this Jan 22, 2025
@lucylq lucylq deleted the gh/lucylq/28/orig branch January 24, 2025 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants