-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
turn on dim order in cadence test #7756
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7756
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 0fef183 with merge base da0d85d (): BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This pull request was exported from Phabricator. Differential Revision: D68246404 |
@pytorchbot label "topic: not user facing" |
Summary: as title Differential Revision: D68246404
a53e36a
to
5e9fc4e
Compare
This pull request was exported from Phabricator. Differential Revision: D68246404 |
Summary: as title Differential Revision: D68246404
5e9fc4e
to
8e7f0bd
Compare
This pull request was exported from Phabricator. Differential Revision: D68246404 |
Summary: This diff turns on dim order in cadence test. Also we get around `to_copy` operator in verifier to keep the verifier check enable. Differential Revision: D68246404
8e7f0bd
to
580d27f
Compare
This pull request was exported from Phabricator. Differential Revision: D68246404 |
Summary: This diff turns on dim order in cadence test. Also we get around `to_copy` operator in verifier to keep the verifier check enable. Differential Revision: D68246404
580d27f
to
b313ace
Compare
This pull request was exported from Phabricator. Differential Revision: D68246404 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like lint error is fairly straightforward, sorry about that! And I guess I did have extra parentheses on that assert
too
Thanks @mcremon-meta for help! Will update first then land it |
b313ace
to
ef9e864
Compare
Summary: This diff turns on dim order in cadence test. Also we get around `to_copy` operator in verifier to keep the verifier check enable. Reviewed By: digantdesai, mcremon-meta Differential Revision: D68246404
This pull request was exported from Phabricator. Differential Revision: D68246404 |
Summary: This diff turns on dim order in cadence test. Also we get around `to_copy` operator in verifier to keep the verifier check enable. Reviewed By: digantdesai, mcremon-meta Differential Revision: D68246404
ef9e864
to
df75fdc
Compare
This pull request was exported from Phabricator. Differential Revision: D68246404 |
Summary: This diff turns on dim order in cadence test. Also we get around `to_copy` operator in verifier to keep the verifier check enable. Reviewed By: digantdesai, mcremon-meta Differential Revision: D68246404
df75fdc
to
9005382
Compare
This pull request was exported from Phabricator. Differential Revision: D68246404 |
Summary: This diff turns on dim order in cadence test. Also we get around `to_copy` operator in verifier to keep the verifier check enable. Reviewed By: digantdesai, mcremon-meta Differential Revision: D68246404
9005382
to
66a8f38
Compare
This pull request was exported from Phabricator. Differential Revision: D68246404 |
Summary: This diff turns on dim order in cadence test. Also we get around `to_copy` operator in verifier to keep the verifier check enable. Differential Revision: D68246404
66a8f38
to
7a01968
Compare
This pull request was exported from Phabricator. Differential Revision: D68246404 |
Summary: This diff turns on dim order in cadence test. Also we get around `to_copy` operator in verifier to keep the verifier check enable. Differential Revision: D68246404
7a01968
to
6e31f41
Compare
This pull request was exported from Phabricator. Differential Revision: D68246404 |
Summary: This diff turns on dim order in cadence test. Also we get around `to_copy` operator in verifier to keep the verifier check enable. Reviewed By: mcremon-meta Differential Revision: D68246404
6e31f41
to
0fef183
Compare
This pull request was exported from Phabricator. Differential Revision: D68246404 |
Differential Revision: D68246404 Pull Request resolved: #7756
Differential Revision: D68246404 Pull Request resolved: pytorch#7756
Summary: as title
Reviewed By: digantdesai
Differential Revision: D68246404