Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

turn on dim order in cadence test #7756

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

Gasoonjia
Copy link
Contributor

Summary: as title

Reviewed By: digantdesai

Differential Revision: D68246404

Copy link

pytorch-bot bot commented Jan 18, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7756

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 0fef183 with merge base da0d85d (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 18, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68246404

@Gasoonjia
Copy link
Contributor Author

@pytorchbot label "topic: not user facing"

Gasoonjia added a commit to Gasoonjia/executorch-1 that referenced this pull request Jan 21, 2025
Summary:

as title

Differential Revision: D68246404
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68246404

Gasoonjia added a commit to Gasoonjia/executorch-1 that referenced this pull request Jan 24, 2025
Summary:

as title

Differential Revision: D68246404
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68246404

Gasoonjia added a commit to Gasoonjia/executorch-1 that referenced this pull request Jan 24, 2025
Summary:


This diff turns on dim order in cadence test. Also we get around `to_copy` operator in verifier to keep the verifier check enable.

Differential Revision: D68246404
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68246404

Gasoonjia added a commit to Gasoonjia/executorch-1 that referenced this pull request Jan 24, 2025
Summary:


This diff turns on dim order in cadence test. Also we get around `to_copy` operator in verifier to keep the verifier check enable.

Differential Revision: D68246404
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68246404

Copy link
Contributor

@mcremon-meta mcremon-meta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like lint error is fairly straightforward, sorry about that! And I guess I did have extra parentheses on that assert too

@Gasoonjia
Copy link
Contributor Author

Looks like lint error is fairly straightforward, sorry about that! And I guess I did have extra parentheses on that assert too

Thanks @mcremon-meta for help! Will update first then land it

Gasoonjia added a commit to Gasoonjia/executorch-1 that referenced this pull request Jan 26, 2025
Summary:


This diff turns on dim order in cadence test. Also we get around `to_copy` operator in verifier to keep the verifier check enable.

Reviewed By: digantdesai, mcremon-meta

Differential Revision: D68246404
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68246404

Gasoonjia added a commit to Gasoonjia/executorch-1 that referenced this pull request Jan 26, 2025
Summary:


This diff turns on dim order in cadence test. Also we get around `to_copy` operator in verifier to keep the verifier check enable.

Reviewed By: digantdesai, mcremon-meta

Differential Revision: D68246404
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68246404

Gasoonjia added a commit to Gasoonjia/executorch-1 that referenced this pull request Jan 26, 2025
Summary:


This diff turns on dim order in cadence test. Also we get around `to_copy` operator in verifier to keep the verifier check enable.

Reviewed By: digantdesai, mcremon-meta

Differential Revision: D68246404
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68246404

Gasoonjia added a commit to Gasoonjia/executorch-1 that referenced this pull request Jan 27, 2025
Summary:


This diff turns on dim order in cadence test. Also we get around `to_copy` operator in verifier to keep the verifier check enable.

Reviewed By: digantdesai, mcremon-meta

Differential Revision: D68246404
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68246404

Gasoonjia added a commit to Gasoonjia/executorch-1 that referenced this pull request Jan 27, 2025
Summary:


This diff turns on dim order in cadence test. Also we get around `to_copy` operator in verifier to keep the verifier check enable.

Differential Revision: D68246404
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68246404

Gasoonjia added a commit to Gasoonjia/executorch-1 that referenced this pull request Jan 27, 2025
Summary:


This diff turns on dim order in cadence test. Also we get around `to_copy` operator in verifier to keep the verifier check enable.

Differential Revision: D68246404
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68246404

Summary:


This diff turns on dim order in cadence test. Also we get around `to_copy` operator in verifier to keep the verifier check enable.

Reviewed By: mcremon-meta

Differential Revision: D68246404
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68246404

@facebook-github-bot facebook-github-bot merged commit 7bc06d1 into pytorch:main Jan 28, 2025
44 of 47 checks passed
YIWENX14 pushed a commit that referenced this pull request Jan 28, 2025
Differential Revision: D68246404

Pull Request resolved: #7756
zonglinpeng pushed a commit to zonglinpeng/executorch that referenced this pull request Jan 30, 2025
Differential Revision: D68246404

Pull Request resolved: pytorch#7756
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants