-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes to SDPA to support no kv cache export #7530
base: gh/tarun292/1/base
Are you sure you want to change the base?
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7530
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit 84e7573 with merge base 68c0208 (): NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
@tarun292 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
q, | ||
k, | ||
v, | ||
input_pos, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tbh I think you can just set this to 0, should work for the no kv cache text decoder as well since it represents start position, so you don't need to set input_pos to torch.tensor(0) in your other pr
Differential Revision: [D67878163](https://our.internmc.facebook.com/intern/diff/D67878163) [ghstack-poisoned]
@tarun292 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
1 similar comment
@tarun292 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Stack from ghstack (oldest at bottom):
Differential Revision: D67878163