Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to SDPA to support no kv cache export #7530

Open
wants to merge 2 commits into
base: gh/tarun292/1/base
Choose a base branch
from

Conversation

tarun292
Copy link
Contributor

@tarun292 tarun292 commented Jan 6, 2025

Copy link

pytorch-bot bot commented Jan 6, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7530

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit 84e7573 with merge base 68c0208 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 6, 2025
@tarun292
Copy link
Contributor Author

tarun292 commented Jan 6, 2025

@tarun292 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

q,
k,
v,
input_pos,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tbh I think you can just set this to 0, should work for the no kv cache text decoder as well since it represents start position, so you don't need to set input_pos to torch.tensor(0) in your other pr

@tarun292
Copy link
Contributor Author

tarun292 commented Jan 6, 2025

@tarun292 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

1 similar comment
@tarun292
Copy link
Contributor Author

tarun292 commented Jan 6, 2025

@tarun292 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants