Add option to redirect stdout and stdcerr to a file for xcrun compatibility #1963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/1963
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 62553ae with merge base f95d88f ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D53255873 |
…bility Summary: XCRun doesn't provide a convenient way to gather logs or know when a program has completed execution. (This is recognized by the dev community: see ios-control/ios-deploy#588 ) We'll solve this by redirecting `stdout` and `stderr` to a file called `/tmp/BENCH_LOG`. Once the benchmark is complete, we'll create an empty file called `/tmp/BENCH_DONE` that we can poll for (let's say, every 5 seconds) to check whether the benchmark has completed. Reviewed By: Jack-Khuu Differential Revision: D53255873
vmpuri
force-pushed
the
export-D53255873
branch
from
da6e888
to
62553ae
Compare
|
This pull request was exported from Phabricator. Differential Revision: D53255873 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
XCRun doesn't provide a convenient way to gather logs or know when a program has completed execution. (This is recognized by the dev community: see ios-control/ios-deploy#588 )
We'll solve this by redirecting
stdoutandstderrto a file called/tmp/BENCH_LOG. Once the benchmark is complete, we'll create an empty file called/tmp/BENCH_DONEthat we can poll for (let's say, every 5 seconds) to check whether the benchmark has completed.Reviewed By: Jack-Khuu
Differential Revision: D53255873