Save 16 KiB by moving part of optimized add/sub to .cpp #11346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Stack from ghstack (oldest at bottom): |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11346
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 57a1e72 with merge base 450d1f9 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
swolchok
added a commit
that referenced
this pull request
Jun 3, 2025
Noticed that this function has a significant template-independent part, so I factored it out. ran test/build_optimized_size_test.sh before/after. here's the output of `size cmake-out/size_test_all_optimized_ops` before/after (other binaries didn't change). before: ``` __TEXT __DATA __OBJC others dec hex 4456448 98304 0 4296359936 4300914688 1005ac000 cmake-out/test/size_test_all_optimized_ops ``` after: ``` __TEXT __DATA __OBJC others dec hex 4440064 98304 0 4296359936 4300898304 1005a8000 cmake-out/test/size_test_all_optimized_ops ``` difference of 16384 bytes. ghstack-source-id: bc550ec ghstack-comment-id: 2937733037 Pull-Request-resolved: #11346
facebook-github-bot
added
the
CLA Signed
mergennachin
approved these changes
Jun 4, 2025
|
Sweet! |
manuelcandales
approved these changes
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that this function has a significant template-independent part, so I factored it out.
ran test/build_optimized_size_test.sh before/after. here's the output of
size cmake-out/size_test_all_optimized_opsbefore/after (other binaries didn't change).before:
after:
difference of 16384 bytes.