Arm backend: Support for dynamic shapes and fix resize bugs

[Burton2000]

Dynamic shapes are detected when converting torch shapes to TOSA shapes, when they contain SymInts rather than regular ints. These are converted to -1s as this is how TOSA represents dynamic shapes.

The resize op needs special handling for dynamic shapes, and will only work when all of the TOSA parameters (scale n/d, offset, border) work out to be constant values independent of the shape.

Also fix bug where align_corners was always set to True, when it should be False

cc @digantdesai @freddan80 @per @zingo @oscarandersson8218

Signed-off-by: Richard Burton [email protected]
Co-authored-by: Robert Hughes @Rob-Hughes-Arm

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11310

• 📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit fc97a9b with merge base a69e28e ():

NEW FAILURES - The following jobs have failed:

• trunk / test-llama-torchao-lowbit / macos-job (gh)
  RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 134
• trunk / unittest-release / macos / macos-job (gh)
  backends/xnnpack/test/ops/test_rsqrt.py::TestRsqrt::test_fp16_rsqrt

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[Burton2000]

@pytorchbot label ciflow/trunk

[pytorch-bot]

To add these label(s) (ciflow/trunk) to the PR, please first approve the workflows that are awaiting approval (scroll to the bottom of this page).

This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows.

[pytorch-bot]

To add the ciflow label ciflow/trunk please first approve the workflows that are awaiting approval (scroll to the bottom of this page).

This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows.

[pytorch-bot]

To add the ciflow label ciflow/trunk please first approve the workflows that are awaiting approval (scroll to the bottom of this page).

This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows.

[zingo]

This PR caused a strange lintrunner error so I rebased it to check if it helped.

[zingo]

@Burton2000 unfortunately it didn't help, it seems this PR cause some lint problems. Without looking at it it might be that one of you changes in a generic class get error when used so if you tests locally you might not see it if you only check changed files in the patch e.g. you might need to use lintrunner without args if you used something like
lintrunner --revision 'HEAD^' -a

[Burton2000]

Looking better now?

[zingo]

Looking better now?

Yes but there is a fail in a Arm backend test now :(

[zingo]

It was
backends/arm/test/models/test_deit_tiny_arm.py
It seems a bit flakey I think the atol might need a bump as it seem to fail now and then, I retriggered the test for you.

[zingo]

MacOS fails are unrelated as this delegate don't build or run on it.