Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Andrewkh/fix nightly 2 #1328

Merged
merged 3 commits into from
Sep 26, 2024
Merged

Andrewkh/fix nightly 2 #1328

merged 3 commits into from
Sep 26, 2024

Conversation

andrewkho
Copy link
Contributor

This time I tested it by manually running a workflow. This branch is prohibted from actually pushing so it fails during push step, but we're able to run and see builds succeed: https://github.com/pytorch/data/actions/runs/11057077541

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 26, 2024
Copy link

@divyanshk divyanshk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this, LGTM!

Copy link

pytorch-bot bot commented Sep 26, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/data/1328

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit a4edf65 with merge base 1a98f21 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@andrewkho andrewkho merged commit ef62e00 into main Sep 26, 2024
70 of 71 checks passed
@andrewkho andrewkho deleted the andrewkh/fix-nightly-2 branch September 26, 2024 17:39
atalman added a commit that referenced this pull request Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants