Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aarch64 to TorchData CICD #1199

Closed
wants to merge 6 commits into from
Closed

Add aarch64 to TorchData CICD #1199

wants to merge 6 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Aug 14, 2023

Please read through our contribution guide prior to
creating your pull request.

  • Note that there is a section on requirements related to adding a new DataPipe.

Fixes #{issue number}

Changes

  • Adding aarch64 workflow to CICD.
  • Setting setup-miniconda to false as conda is installed from "Set linux aarch64 CI"
  • Updated post_build_script_linux.sh to support different CPU arch types by finding the arch from there the script is executed.
  • Remove torchvision from domain_ci testing as the newer versions of torchvision do not use torchdata.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 14, 2023
@ghost ghost changed the title Add aarch64 Add aarch64 to TorchData CICD Aug 14, 2023
@ghost
Copy link
Author

ghost commented Aug 15, 2023

@atalman Mind looking at this? Believe this should allow aarch64 TorchData build.

Copy link
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM we can merge if CI is green

@msaroufim
Copy link
Member

msaroufim commented Aug 15, 2023

Btw the torchvision tests are expected to fail because they've dropped their use of torchdata so the only job that needs to be green is the BUILD AARCH64

You can however fix the torchvision tests if you pin to an older version https://github.com/pytorch/data/blob/main/.github/workflows/domain_ci.yml#L13

@ghost
Copy link
Author

ghost commented Aug 15, 2023

Btw the torchvision tests are expected to fail because they've dropped their use of torchdata so the only job that needs to be green is the BUILD AARCH64

You can however fix the torchvision tests if you pin to an older version https://github.com/pytorch/data/blob/main/.github/workflows/domain_ci.yml#L13

Since this is dropped for torchvision, do we even need the test anymore?

@msaroufim
Copy link
Member

yeah probably not, feel free to delete and I can retrigger CI

@msaroufim
Copy link
Member

msaroufim commented Aug 15, 2023

idk what's going on with the linter but try running precommit and see if that unblocks https://github.com/pytorch/data/blob/main/CONTRIBUTING.md#code-style

@ghost
Copy link
Author

ghost commented Aug 15, 2023

Looks like Prettier has an issue with "warning" section of the README.md. Wonder how that got by. Will update this PR to include Prettier's update to the README.md which should clear the lint issue. Going to wait and see if the build completes first.

@ghost
Copy link
Author

ghost commented Aug 15, 2023

@msaroufim think we are good this time. Want to give it another try?

@msaroufim msaroufim self-requested a review August 15, 2023 22:18
@msaroufim
Copy link
Member

Err not sure what to do here there's way too many failing tests that I'm not sure this is right to merge - wdyt @atalman ?

@ghost
Copy link
Author

ghost commented Aug 16, 2023

7 of the 8 were Error: The operation was canceled. we know why they were canceled?MyPy looks like an internal error. Not sure what to think about that one.

@facebook-github-bot
Copy link
Contributor

@msaroufim has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@ghost
Copy link
Author

ghost commented Aug 17, 2023

am closing this as the repo is a little, on pause.

@ghost ghost closed this Aug 17, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants