Skip to content

Detach tensor in gen_candidates_scipy to avoid test failure due to new warning #2797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions botorch/generation/gen.py
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ def f_np_wrapper(x: npt.NDArray, f: Callable):
if initial_conditions.dtype != torch.double:
msg += " Consider using `dtype=torch.double`."
raise OptimizationGradientError(msg, current_x=x)
fval = loss.item()
fval = loss.detach().item()
return fval, gradf

else:
Expand All @@ -215,7 +215,7 @@ def f_np_wrapper(x: npt.NDArray, f: Callable):
with torch.no_grad():
X_fix = fix_features(X=X, fixed_features=fixed_features)
loss = f(X_fix).sum()
fval = loss.item()
fval = loss.detach().item()
return fval

if nonlinear_inequality_constraints:
Expand Down