Make input transfroms Modules by default #2607
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D65338444 |
Summary: `InputTransform`s are required to be `torch.nn.Module` subclasses but the base class does not inherit from `torch.nn.Module`. This leads to type checker complaints when calling methods like `.to(...)`, since it doesn't know that they are `Module`s. This was originally motivated by the inheritance order of `Warp` transform, as we want `GPyTorchModule` methods to take precedence over `torch.nn.Module`. However, this not actually a concern since the `GPyTorchModule` comes first in the MRO of `Warp` regardless of whether `InputTransform` inherits from `Module` (since `GPyTorchModule` itself inherits from `Module` as well). This diff updates `InputTransform` to inherit from `Module` and removes the redundant `Module` inheritance from subclasses. Differential Revision: D65338444
saitcakmak
force-pushed
the
export-D65338444
branch
from
68d0ed3
to
9c4581f
Compare
|
This pull request was exported from Phabricator. Differential Revision: D65338444 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2607 +/- ##
=======================================
Coverage 99.98% 99.98%
=======================================
Files 196 196
Lines 17372 17372
=======================================
Hits 17370 17370
Misses 2 2 ☔ View full report in Codecov by Sentry. |
|
This pull request has been merged in 3ca48d0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
InputTransforms are required to betorch.nn.Modulesubclasses but the base class does not inherit fromtorch.nn.Module. This leads to type checker complaints when calling methods like.to(...), since it doesn't know that they areModules.This was originally motivated by the inheritance order of
Warptransform, as we wantGPyTorchModulemethods to take precedence overtorch.nn.Module. However, this not actually a concern since theGPyTorchModulecomes first in the MRO ofWarpregardless of whetherInputTransforminherits fromModule(sinceGPyTorchModuleitself inherits fromModuleas well).This diff updates
InputTransformto inherit fromModuleand removes the redundantModuleinheritance from subclasses.Differential Revision: D65338444