Remove posterior_transform from info-theoretic acquisition functions #2590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D64698976 |
hvarfner
pushed a commit
to hvarfner/botorch
that referenced
this pull request
Oct 21, 2024
…ytorch#2590) Summary: Pull Request resolved: pytorch#2590 Differential Revision: D64698976
hvarfner
pushed a commit
to hvarfner/botorch
that referenced
this pull request
Oct 22, 2024
…ytorch#2590) Summary: Pull Request resolved: pytorch#2590 Differential Revision: D64698976
hvarfner
force-pushed
the
export-D64698976
branch
from
7156e0d
to
028cdea
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64698976 |
hvarfner
force-pushed
the
export-D64698976
branch
from
028cdea
to
0900161
Compare
hvarfner
pushed a commit
to hvarfner/botorch
that referenced
this pull request
Oct 22, 2024
…ytorch#2590) Summary: Pull Request resolved: pytorch#2590 Differential Revision: D64698976
|
This pull request was exported from Phabricator. Differential Revision: D64698976 |
hvarfner
pushed a commit
to hvarfner/botorch
that referenced
this pull request
Oct 22, 2024
…ytorch#2590) Summary: Pull Request resolved: pytorch#2590 Differential Revision: D64698976
hvarfner
force-pushed
the
export-D64698976
branch
from
0900161
to
dc5fb3c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64698976 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2590 +/- ##
=======================================
Coverage 99.98% 99.98%
=======================================
Files 196 196
Lines 17345 17352 +7
=======================================
+ Hits 17343 17350 +7
Misses 2 2 ☔ View full report in Codecov by Sentry. |
hvarfner
pushed a commit
to hvarfner/botorch
that referenced
this pull request
Oct 22, 2024
…ytorch#2590) Summary: Pull Request resolved: pytorch#2590 Differential Revision: D64698976
hvarfner
force-pushed
the
export-D64698976
branch
from
dc5fb3c
to
46bc7c8
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64698976 |
hvarfner
pushed a commit
to hvarfner/botorch
that referenced
this pull request
Oct 22, 2024
…ytorch#2590) Summary: Pull Request resolved: pytorch#2590 Differential Revision: D64698976
hvarfner
force-pushed
the
export-D64698976
branch
from
46bc7c8
to
d824014
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64698976 |
hvarfner
pushed a commit
to hvarfner/botorch
that referenced
this pull request
Oct 22, 2024
hvarfner
force-pushed
the
export-D64698976
branch
from
d824014
to
0d0643b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64698976 |
hvarfner
pushed a commit
to hvarfner/botorch
that referenced
this pull request
Oct 22, 2024
hvarfner
force-pushed
the
export-D64698976
branch
from
0d0643b
to
02f1b1a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64698976 |
added 2 commits
October 23, 2024 06:53
…samples (pytorch#2576) Summary: Added `posterior_transform` arg to get_optimal_samples to enable posterior sampling-based (xES, TestSet IG) acquisition functions with minimization problems. Intended use in one-shot settings. Reviewed By: saitcakmak Differential Revision: D64266499
hvarfner
force-pushed
the
export-D64698976
branch
from
02f1b1a
to
1c39edf
Compare
|
This pull request was exported from Phabricator. Differential Revision: D64698976 |
|
This pull request has been merged in 563cd95. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D64698976