Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PosteriorTransform to get_optimal_samples and optimize_posterior_samples #2576

Closed
wants to merge 1 commit into from

Conversation

hvarfner
Copy link
Contributor

Summary: Added posterior_transform arg to get_optimal_samples to enable posterior sampling-based (xES, TestSet IG) acquisition functions with minimization problems. Intended use in one-shot settings with TSIG with Target-aware models (e.g. D63135028), which otherwise cannot be used in minimization problems, nor with multi-objective.

Differential Revision: D64266499

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Oct 15, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64266499

hvarfner pushed a commit to hvarfner/botorch that referenced this pull request Oct 15, 2024
…samples (pytorch#2576)

Summary:

Added `posterior_transform` arg to get_optimal_samples to enable posterior sampling-based (xES, TestSet IG) acquisition functions with minimization problems. Intended use in one-shot settings.

Differential Revision: D64266499
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64266499

hvarfner pushed a commit to hvarfner/botorch that referenced this pull request Oct 15, 2024
…samples (pytorch#2576)

Summary:

Added `posterior_transform` arg to get_optimal_samples to enable posterior sampling-based (xES, TestSet IG) acquisition functions with minimization problems. Intended use in one-shot settings.

Differential Revision: D64266499
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64266499

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.98%. Comparing base (b9d863d) to head (91c748a).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2576   +/-   ##
=======================================
  Coverage   99.98%   99.98%           
=======================================
  Files         196      196           
  Lines       17340    17350   +10     
=======================================
+ Hits        17338    17348   +10     
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

hvarfner pushed a commit to hvarfner/botorch that referenced this pull request Oct 16, 2024
…samples (pytorch#2576)

Summary:

Added `posterior_transform` arg to get_optimal_samples to enable posterior sampling-based (xES, TestSet IG) acquisition functions with minimization problems. Intended use in one-shot settings.

Differential Revision: D64266499
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64266499

hvarfner pushed a commit to hvarfner/botorch that referenced this pull request Oct 16, 2024
…samples (pytorch#2576)

Summary:

Added `posterior_transform` arg to get_optimal_samples to enable posterior sampling-based (xES, TestSet IG) acquisition functions with minimization problems. Intended use in one-shot settings.

Differential Revision: D64266499
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64266499

hvarfner pushed a commit to hvarfner/botorch that referenced this pull request Oct 21, 2024
…samples (pytorch#2576)

Summary:

Added `posterior_transform` arg to get_optimal_samples to enable posterior sampling-based (xES, TestSet IG) acquisition functions with minimization problems. Intended use in one-shot settings.

Differential Revision: D64266499
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64266499

hvarfner pushed a commit to hvarfner/botorch that referenced this pull request Oct 22, 2024
…samples (pytorch#2576)

Summary:

Added `posterior_transform` arg to get_optimal_samples to enable posterior sampling-based (xES, TestSet IG) acquisition functions with minimization problems. Intended use in one-shot settings.

Differential Revision: D64266499
hvarfner pushed a commit to hvarfner/botorch that referenced this pull request Oct 22, 2024
…samples (pytorch#2576)

Summary:

Added `posterior_transform` arg to get_optimal_samples to enable posterior sampling-based (xES, TestSet IG) acquisition functions with minimization problems. Intended use in one-shot settings.

Differential Revision: D64266499
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64266499

hvarfner pushed a commit to hvarfner/botorch that referenced this pull request Oct 22, 2024
…samples (pytorch#2576)

Summary:

Added `posterior_transform` arg to get_optimal_samples to enable posterior sampling-based (xES, TestSet IG) acquisition functions with minimization problems. Intended use in one-shot settings.

Differential Revision: D64266499
hvarfner pushed a commit to hvarfner/botorch that referenced this pull request Oct 22, 2024
…samples (pytorch#2576)

Summary:

Added `posterior_transform` arg to get_optimal_samples to enable posterior sampling-based (xES, TestSet IG) acquisition functions with minimization problems. Intended use in one-shot settings.

Differential Revision: D64266499
hvarfner pushed a commit to hvarfner/botorch that referenced this pull request Oct 22, 2024
…samples (pytorch#2576)

Summary:

Added `posterior_transform` arg to get_optimal_samples to enable posterior sampling-based (xES, TestSet IG) acquisition functions with minimization problems. Intended use in one-shot settings.

Differential Revision: D64266499
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64266499

hvarfner pushed a commit to hvarfner/botorch that referenced this pull request Oct 22, 2024
…samples (pytorch#2576)

Summary:

Added `posterior_transform` arg to get_optimal_samples to enable posterior sampling-based (xES, TestSet IG) acquisition functions with minimization problems. Intended use in one-shot settings.

Differential Revision: D64266499
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64266499

hvarfner pushed a commit to hvarfner/botorch that referenced this pull request Oct 22, 2024
…samples (pytorch#2576)

Summary:

Added `posterior_transform` arg to get_optimal_samples to enable posterior sampling-based (xES, TestSet IG) acquisition functions with minimization problems. Intended use in one-shot settings.

Differential Revision: D64266499
…samples (pytorch#2576)

Summary:

Added `posterior_transform` arg to get_optimal_samples to enable posterior sampling-based (xES, TestSet IG) acquisition functions with minimization problems. Intended use in one-shot settings.

Differential Revision: D64266499
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D64266499

hvarfner pushed a commit to hvarfner/botorch that referenced this pull request Oct 22, 2024
…samples (pytorch#2576)

Summary:

Added `posterior_transform` arg to get_optimal_samples to enable posterior sampling-based (xES, TestSet IG) acquisition functions with minimization problems. Intended use in one-shot settings.

Differential Revision: D64266499
hvarfner pushed a commit to hvarfner/botorch that referenced this pull request Oct 22, 2024
…samples (pytorch#2576)

Summary:

Added `posterior_transform` arg to get_optimal_samples to enable posterior sampling-based (xES, TestSet IG) acquisition functions with minimization problems. Intended use in one-shot settings.

Reviewed By: saitcakmak

Differential Revision: D64266499
hvarfner pushed a commit to hvarfner/botorch that referenced this pull request Oct 22, 2024
…samples (pytorch#2576)

Summary:

Added `posterior_transform` arg to get_optimal_samples to enable posterior sampling-based (xES, TestSet IG) acquisition functions with minimization problems. Intended use in one-shot settings.

Reviewed By: saitcakmak

Differential Revision: D64266499
hvarfner pushed a commit to hvarfner/botorch that referenced this pull request Oct 23, 2024
…samples (pytorch#2576)

Summary:

Added `posterior_transform` arg to get_optimal_samples to enable posterior sampling-based (xES, TestSet IG) acquisition functions with minimization problems. Intended use in one-shot settings.

Reviewed By: saitcakmak

Differential Revision: D64266499
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 04193e9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants